Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/509 remove embedded bundles support #707

Merged
merged 2 commits into from
Dec 31, 2023

Conversation

pnoltes
Copy link
Contributor

@pnoltes pnoltes commented Dec 30, 2023

This PR removes support for embedded bundles.

Although embedding bundles as part of an executable is interesting, it is not part of the OSGi spec and it is proven that this requires some maintenance effort (cmake changes, use of assembly, security changes, etc).

Maybe in the future something like a executable (far) jar from bndtools can be adopted for Apache Celix:

Bndtools can export a bndrun file to an executable JAR. This is a JAR that can be executed in any Java VM. The JAR contains the framework and all required bundles. When it runs with the venerable java -jar x.jar command it will unpack itself and launch a framework. The continuous integration can build this executable JAR.

So an executable that contains and extracts the Apache Celix container executable, its required bundles and possible some libs.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ea03bc) 88.39% compared to head (07bf252) 88.35%.

❗ Current head 07bf252 differs from pull request most recent head 4224357. Consider uploading reports for the commit 4224357 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
- Coverage   88.39%   88.35%   -0.05%     
==========================================
  Files         215      215              
  Lines       24618    24500     -118     
==========================================
- Hits        21762    21646     -116     
+ Misses       2856     2854       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@PengZheng PengZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnoltes pnoltes merged commit ab7b7af into master Dec 31, 2023
28 checks passed
@pnoltes pnoltes deleted the feature/509-remove-embedded-bundles-support branch December 31, 2023 16:50
@rlenferink
Copy link
Member

Maybe in the future something like a executable (far) jar from bndtools can be adopted for Apache Celix

@pnoltes if this is an idea for the future, I think it would be wise to create an issue for it with a brief explanation of the wish (and possibly referring to this PR as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants