Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/509 remove pubsub #703

Merged
merged 7 commits into from
Dec 25, 2023
Merged

Feature/509 remove pubsub #703

merged 7 commits into from
Dec 25, 2023

Conversation

pnoltes
Copy link
Contributor

@pnoltes pnoltes commented Dec 22, 2023

This PR removes the pubsub feature from Apache Celix.

As stated in #509, pubsub is not part of the OSGi specification, and I believe it would be better for Apache Celix to focus on features from the OSGi spec, perhaps with a few additional small features.

This change should simplify the maintenance of Apache Celix and contribute to its growth as an even more stable framework.

Note that the pubsub feature is still available in the Apache Celix 2.4.x release. Should there be renewed interest in the future, we can consider reintroducing it based on community needs and contributions.

It fixes #466
It fixes #520
It fixes #295
It fixes #222
It fixes #221
It fixes #205
It fixes #123

@codecov-commenter
Copy link

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (2a5058f) 84.25% compared to head (6856982) 88.26%.

❗ Current head 6856982 differs from pull request most recent head efad168. Consider uploading reports for the commit efad168 to get more accurate results

Files Patch % Lines
...ration/src/TestExportImportRemoteServiceFactory.cc 83.83% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
+ Coverage   84.25%   88.26%   +4.01%     
==========================================
  Files         248      215      -33     
  Lines       31124    24562    -6562     
==========================================
- Hits        26222    21679    -4543     
+ Misses       4902     2883    -2019     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@PengZheng PengZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I noticed a huge bump in code coverage. If we stick to the new coding convention when refactoring existing code and implementing new functionalities, 95% overall coverage is not a dream.

@PengZheng PengZheng merged commit d62eeef into master Dec 25, 2023
28 checks passed
@PengZheng PengZheng deleted the feature/509-remove-pubsub branch December 25, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment