Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/509 remove avpr #697

Merged
merged 8 commits into from
Dec 13, 2023
Merged

Feature/509 remove avpr #697

merged 8 commits into from
Dec 13, 2023

Conversation

PengZheng
Copy link
Contributor

This PR performs the planned removal of avpr from libdfi, as mentioned in #509.
It will also close #158.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8956987) 83.47% compared to head (d2d5974) 84.26%.

❗ Current head d2d5974 differs from pull request most recent head 578869e. Consider uploading reports for the commit 578869e to get more accurate results

Files Patch % Lines
...te_service_admin_dfi/src/import_registration_dfi.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
+ Coverage   83.47%   84.26%   +0.78%     
==========================================
  Files         254      248       -6     
  Lines       32988    31124    -1864     
==========================================
- Hits        27538    26226    -1312     
+ Misses       5450     4898     -552     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pnoltes pnoltes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a small remark about a log level, but overall LGTM.

libs/framework/src/bundle_archive.c Outdated Show resolved Hide resolved
@PengZheng PengZheng merged commit 5393c2a into master Dec 13, 2023
28 checks passed
@PengZheng PengZheng deleted the feature/509-remove-avpr branch December 13, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dynMessage_parseAvpr
3 participants