#647: Fix use-after-free in celix_framework_scheduleEvent. #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
==========================================
- Coverage 81.67% 81.66% -0.01%
==========================================
Files 252 252
Lines 32602 32603 +1
==========================================
- Hits 26627 26626 -1
- Misses 5975 5977 +2
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
PengZheng
commented
Nov 3, 2023
| celixThreadCondition_broadcast(&fw->dispatcher.cond); //notify dispatcher thread for newly added scheduled event | ||
| celixThreadMutex_unlock(&fw->dispatcher.mutex); | ||
|
|
||
| return celix_scheduledEvent_getId(event); | ||
| return id; |
There was a problem hiding this comment.
Accessing event id without lock protection leads to use-after-free.
I just ignored this last line when this was first encountered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really should have fixed this before 2.4.0 release when reporting #647.
@pnoltes This needs to be backported to support/2.4