-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/509 remove osgi defines #679
Conversation
Also renames CELIX_FRAMEWORK_FRAMEWORK_CACHE_DIR config property to CELIX_FRAMEWORK_CACHE_DIR.
# Conflicts: # CHANGES.md
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 81.68% 81.69%
=======================================
Files 252 252
Lines 32633 32589 -44
=======================================
- Hits 26657 26624 -33
+ Misses 5976 5965 -11
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup. When all deprecated APIs are removed, I think the footprint of the framework library would be further reduced.
LGTM
.../remote_services/remote_service_admin_shm_v2/rsa_shm/gtest/src/RsaShmIntegrationTestSuite.cc
Outdated
Show resolved
Hide resolved
…create" config property
This PR removes the
OSGI_
define constants and the usage of these constants.Note that all
OSGI_
define constants were already deprecated.This PR also:
bundle_activator.h
headerSERVICE_PID
constant, because this is part of the config admin and should not be defined in the framework constants.