Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/509 remove osgi defines #679

Merged
merged 16 commits into from
Nov 6, 2023
Merged

Conversation

pnoltes
Copy link
Contributor

@pnoltes pnoltes commented Oct 29, 2023

This PR removes the OSGI_ define constants and the usage of these constants.

Note that all OSGI_ define constants were already deprecated.

This PR also:

  • Removes usage of "cosgi.auto.start." config properties.
  • Removes the deprecated usage of deprecated bundle activator symbols and the bundle_activator.h header
  • Removes the SERVICE_PID constant, because this is part of the config admin and should not be defined in the framework constants.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023

Codecov Report

Merging #679 (0a3b720) into master (5cdd18d) will increase coverage by 0.00%.
The diff coverage is 88.88%.

❗ Current head 0a3b720 differs from pull request most recent head f495697. Consider uploading reports for the commit f495697 to get more accurate results

@@           Coverage Diff           @@
##           master     #679   +/-   ##
=======================================
  Coverage   81.68%   81.69%           
=======================================
  Files         252      252           
  Lines       32633    32589   -44     
=======================================
- Hits        26657    26624   -33     
+ Misses       5976     5965   -11     
Files Coverage Δ
bundles/logging/log_admin/src/celix_log_admin.c 99.76% <100.00%> (ø)
...les/pubsub/pubsub_admin_tcp/src/pubsub_tcp_admin.c 50.50% <100.00%> (ø)
...b/pubsub_admin_tcp/src/pubsub_tcp_topic_receiver.c 68.87% <100.00%> (ø)
...sub/pubsub_admin_tcp/src/pubsub_tcp_topic_sender.c 84.01% <100.00%> (ø)
...ubsub_admin_websocket/src/pubsub_websocket_admin.c 42.47% <100.00%> (ø)
...in_websocket/src/pubsub_websocket_topic_receiver.c 67.47% <100.00%> (ø)
...les/pubsub/pubsub_admin_zmq/src/pubsub_zmq_admin.c 52.96% <100.00%> (ø)
...b/pubsub_admin_zmq/src/pubsub_zmq_topic_receiver.c 76.64% <100.00%> (ø)
...sub/pubsub_admin_zmq/src/pubsub_zmq_topic_sender.c 84.05% <100.00%> (ø)
..._protocol_wire_v1/src/ps_wire_protocol_activator.c 100.00% <100.00%> (ø)
... and 36 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PengZheng PengZheng self-requested a review October 31, 2023 10:16
Copy link
Contributor

@PengZheng PengZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. When all deprecated APIs are removed, I think the footprint of the framework library would be further reduced.

LGTM

@pnoltes pnoltes merged commit 25463cf into master Nov 6, 2023
28 checks passed
@pnoltes pnoltes deleted the feature/509-remove-osgi-defines branch November 6, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants