Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/509 remove deprecated cmake functions #678

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

pnoltes
Copy link
Contributor

@pnoltes pnoltes commented Oct 28, 2023

Removes deprecated Apache Celix CMake function.

This includes:

  • bundle functions without a celix prefix or infix
  • functions to create a dockerfile and docker image
  • functions to create a runtime dir

This includes bundle functions without a celix_ prefix,
runtime functions and docker functions.
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Merging #678 (e17a38e) into master (2028c59) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
- Coverage   81.67%   81.64%   -0.04%     
==========================================
  Files         252      252              
  Lines       32633    32633              
==========================================
- Hits        26654    26644      -10     
- Misses       5979     5989      +10     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@PengZheng PengZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnoltes pnoltes merged commit 5cdd18d into master Oct 29, 2023
28 checks passed
@pnoltes pnoltes deleted the feature/509-remove-deprecated-cmake-functions branch October 29, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants