Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/509 remove service lang support #677

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

pnoltes
Copy link
Contributor

@pnoltes pnoltes commented Oct 28, 2023

Remove support for the "service.lang" service property and its usage.

The idea behind the "service.lang" property was to distinguish between C or C++ services, but this feature was confusion
and with a good service naming convention not needed.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Merging #677 (9f40a29) into master (eeed2c6) will increase coverage by 0.01%.
The diff coverage is 88.88%.

❗ Current head 9f40a29 differs from pull request most recent head 70d22bf. Consider uploading reports for the commit 70d22bf to get more accurate results

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   81.65%   81.66%   +0.01%     
==========================================
  Files         252      252              
  Lines       32656    32633      -23     
==========================================
- Hits        26664    26649      -15     
+ Misses       5992     5984       -8     
Files Coverage Δ
...undles/pubsub/pubsub_admin_tcp/src/psa_activator.c 100.00% <ø> (ø)
...b/pubsub_admin_tcp/src/pubsub_tcp_topic_receiver.c 68.87% <ø> (-0.09%) ⬇️
...in_websocket/src/pubsub_websocket_topic_receiver.c 67.47% <ø> (-0.09%) ⬇️
...undles/pubsub/pubsub_admin_zmq/src/psa_activator.c 100.00% <ø> (ø)
...b/pubsub_admin_zmq/src/pubsub_zmq_topic_receiver.c 76.64% <ø> (-0.07%) ⬇️
...ubsub/pubsub_spi/src/pubsub_interceptors_handler.c 98.09% <ø> (-0.02%) ⬇️
...ubsub/pubsub_topology_manager/src/pstm_activator.c 100.00% <ø> (ø)
bundles/pubsub/pubsub_utils/src/pubsub_matching.c 78.12% <ø> (-0.17%) ⬇️
...te_service_admin_dfi/src/export_registration_dfi.c 79.67% <ø> (-0.11%) ⬇️
...n_shm_v2/rsa_shm/src/rsa_shm_export_registration.c 100.00% <ø> (ø)
... and 7 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@PengZheng PengZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnoltes pnoltes merged commit 2028c59 into master Oct 29, 2023
28 checks passed
@pnoltes pnoltes deleted the feature/509-remove-service-lang-support branch October 29, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants