Hotfix/bundle packagin zip #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously RPATH rewrite for bundles does not work because `install(FILES)` deos not overwrite existing files. This changes fix it by removing the file to be overwritten. It all fix broken bundle installation using zip.
Codecov Report
@@ Coverage Diff @@
## master #641 +/- ##
=======================================
Coverage 81.61% 81.62%
=======================================
Files 260 260
Lines 34680 34680
=======================================
+ Hits 28303 28306 +3
+ Misses 6377 6374 -3 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously RPATH rewrite for bundles does not work because
install(FILES)does not overwrite existing files.This change fixes it by removing the file to be overwritten. It also fixes broken bundle installation using zip.