Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move celix::Exception to utils and refactor to use using ctor #570

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

pnoltes
Copy link
Contributor

@pnoltes pnoltes commented Jun 4, 2023

Small PR that:

  • Moves celix::Exception to celix utils
  • Adds 2 exception for service registration and tracking
  • Simplifies exception by using the runtime_error ctor

@codecov-commenter
Copy link

Codecov Report

Merging #570 (b6f395c) into master (2efed0a) will increase coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head b6f395c differs from pull request most recent head 9fd85c9. Consider uploading reports for the commit 9fd85c9 to get more accurate results

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
+ Coverage   78.03%   78.07%   +0.03%     
==========================================
  Files         230      229       -1     
  Lines       35022    35016       -6     
==========================================
+ Hits        27330    27337       +7     
+ Misses       7692     7679      -13     
Impacted Files Coverage Δ
libs/framework/include/celix/ServiceRegistration.h 96.63% <0.00%> (ø)
libs/framework/include/celix/Trackers.h 92.00% <0.00%> (ø)
libs/utils/include/celix/Filter.h 100.00% <ø> (+4.00%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@PengZheng PengZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnoltes pnoltes merged commit f9ada53 into master Jun 5, 2023
@pnoltes pnoltes deleted the feature/simplify-cxx-exceptions branch June 5, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants