-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated header for public api #542
base: master
Are you sure you want to change the base?
Remove deprecated header for public api #542
Conversation
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
- Coverage 77.43% 77.41% -0.03%
==========================================
Files 225 225
Lines 34532 34523 -9
==========================================
- Hits 26739 26725 -14
- Misses 7793 7798 +5
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, with exception of the hashmap changes for the services.
These are backwards incompatible changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing the hashmap for a service is a backwards incompatible update. I think we should postpone that until Celix 3.0.0
@@ -29,6 +29,7 @@ | |||
|
|||
#include "endpoint_listener.h" | |||
#include "remote_service_admin.h" | |||
#include "celix_long_hash_map.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing the hashmap for a service is a backwards incompatible update. I think we should postpone that until Celix 3.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK,Let's merge it until Celix 3.0.0
I agree with @pnoltes. Let's merge it for 3.0.0. |
This reverts commit 1998e10.
Now it is good time to re-attempt this PR. @xuzhenbao |
Given that pubsub has already been removed, it this PR already done? @xuzhenbao |
Thanks for the reminder. Maybe I need to plan a time to update this PR. |
fix #538
1.Remove the deprecated headers used by rsa_spi
2.Remove the deprecated headers used by pubsub_spi
3.Remove the deprecated headers used by conan_test_package
4. add conan_test_package for rsa_discovery_zeroconf.