Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove service_tracker.h service_tracker_customizer.h header and bundleContext_getServiceReference #87

Open
rlenferink opened this issue Sep 28, 2019 · 3 comments
Open

Remove service_tracker.h service_tracker_customizer.h header and bundleContext_getServiceReference #87

rlenferink opened this issue Sep 28, 2019 · 3 comments
Assignees
@pnoltes
Labels
component/framework Categorizes an issue or PR relevant to the framework. kind/improvement Categorizes issue or PR as related to improvements.
Milestone
3.0.0

Comments

@rlenferink
Copy link
Member

The service_tracker.h and service_tracker_custimizer.h should be removed. Service tracker should be control-able from the bundle context (see CELIX-441)
Also remove the bundleContext_getServiceReference(s) this should also been unnecessary because of CEILX-441.

This make to total Celix API smaller

Original creation date: 10/Apr/2018
Reporter: @pnoltes
@rlenferink rlenferink added component/framework Categorizes an issue or PR relevant to the framework. kind/improvement Categorizes issue or PR as related to improvements. labels Sep 28, 2019
@rlenferink rlenferink added this to the 3.0.0 milestone Sep 28, 2019
@pnoltes pnoltes self-assigned this Feb 10, 2024
@pnoltes
Copy link
Contributor

pnoltes commented Feb 10, 2024

As discussed in https://lists.apache.org/thread/6gp5crw1pp408jw2fbwlg149n5rm36pv before the service tracker headers can be removed from the public API some additional tracker API in the bundle context is needed.

Mainly to be able to use tracked services out side of the celix event thread.

pnoltes added a commit that referenced this issue Feb 11, 2024
@pnoltes
gh-87: Change signature celix_bundleContext_trackServices
7b37d72 
Also update the celix_bundleContext_trackServices usage.
pnoltes added a commit that referenced this issue Feb 11, 2024
@pnoltes
gh-87: Add celix_bundle_context_type.h header.
9d2e7a5
pnoltes added a commit that referenced this issue Feb 11, 2024
@pnoltes
gh-87: Add useService(s) methods to C++ ServiceTracker
9321f51
@PengZheng PengZheng linked a pull request Feb 21, 2024 that will close this issue
Feature/87 add additional svc tracker bundle context funtions #729
Merged
PengZheng added a commit that referenced this issue Feb 22, 2024
@PengZheng
gh-87: Fix leaks caused by realloc failure.
272bd4f
pnoltes added a commit that referenced this issue Feb 25, 2024
@pnoltes
gh-87: Move svc tracker state fields to an anon state struct
5446bf0
pnoltes added a commit that referenced this issue Feb 25, 2024
@pnoltes
gh-87: Refactor bnd ctx to use a rwlock instead of mutex.
eb6e699 
Also:
 - Remove celix_bundleContext_trackService and
   celix_bundleContext_trackServiceAsync functions.
 - Update doxygen for useTrackedService* calls.
 - Remove celix_bundle_destroyServiceTrackerList. function
   by return an array list with a configured remove callback.
 - Remove waitTimeoutInSeconds option for
   celix_tracked_service_use_options_t.
pnoltes added a commit that referenced this issue Feb 25, 2024
@pnoltes
gh-87: Revert clear tracker maps in bnd ctx cleanup.
8f2f552
@pnoltes
Copy link
Contributor

pnoltes commented Feb 25, 2024 •
edited
Loading

With the addition of celix_bundleContext_useTrackedService* functions, the functions celix_bundleContext_useService* and methods celix::BundleContext::useService* are functional superfluous and less ideal to use (more prone to deadlocks).

  • Remove the the functions celix_bundleContext_useService* and methods celix::BundleContext::useService* to decrease the code size and improve the maintainability. Also introduce some testing methods to replace the useService with wait timeout usecase for testing.

pnoltes added a commit that referenced this issue Feb 25, 2024
@pnoltes
gh-87: Replace trackService usage in rsa test with trackServiceWithOp…
102cd33 
…tions
@PengZheng PengZheng removed a link to a pull request Feb 26, 2024
Feature/87 add additional svc tracker bundle context funtions #729
Merged
PengZheng added a commit that referenced this issue Feb 26, 2024
@PengZheng
gh-87: Remove unused APIs.
67b1240
PengZheng added a commit that referenced this issue Feb 26, 2024
@PengZheng
gh-87: Fix crash caused by wait on event loop.
c44da39
PengZheng added a commit that referenced this issue Feb 26, 2024
@PengZheng
gh-87: Add test case to wait for non-existing tracker.
13fb823
PengZheng added a commit that referenced this issue Feb 27, 2024
@PengZheng
gh-87: Support lock stealing from a lock guard.
b2d197e 
Fix race condition in `celix_bundleContext_getDependencyManager` and avoid write lock when possible.
PengZheng added a commit that referenced this issue Feb 27, 2024
@PengZheng
gh-87: Avoid write lock in bundleContext_cleanupXXX when possible and…
8ca876d 
… fix possible nullptr dereference.
pnoltes added a commit that referenced this issue Mar 3, 2024
@pnoltes
gh-87: Add test to call useTrackedService on the event thread.
dbadfeb
pnoltes added a commit that referenced this issue Mar 3, 2024
@pnoltes
gh-87: Support creating service tracker inside a useTrackedService call
e665364
PengZheng added a commit that referenced this issue Mar 4, 2024
@PengZheng
gh-87: Address review issues in gh-734.
3c3227a 
1. Use acquire-release pair to synchronize the service user with the service stopper.
2. Reduce CPU usage when waiting for service user.
3. Fix gcc -Wstringop-truncation warning.
pnoltes added a commit that referenced this issue Mar 9, 2024
@pnoltes
gh-87: Refactor ctx useService* impl to reuse service tracker.
03c0a2a 
Note that also means that useService* functions and
methods are no longer use-able in the Celix event thread.
pnoltes added a commit that referenced this issue Mar 9, 2024
@pnoltes
gh-87: Remove use direct and sod option from useService* functions
f0e1b22
pnoltes added a commit that referenced this issue Mar 24, 2024
@pnoltes
gh-87: Resolve merge issues
016c366
pnoltes added a commit that referenced this issue Mar 24, 2024
@pnoltes
gh-87: Refactor convert string to typed array utils functions
5bb3859
pnoltes added a commit that referenced this issue Mar 24, 2024
@pnoltes
gh-87: Refactor properties and filter to use typed array lists.
0ad0e94
pnoltes added a commit that referenced this issue Mar 24, 2024
@pnoltes
gh-87: Update useService doxygen documentation
3d1d8bc
pnoltes added a commit that referenced this issue Mar 24, 2024
@pnoltes
gh-87: Update conan test package useService usage
9776daf
@pnoltes
Copy link
Contributor

pnoltes commented Mar 24, 2024

With the addition of celix_bundleContext_useTrackedService* functions, the functions celix_bundleContext_useService* and methods celix::BundleContext::useService* are functional superfluous and less ideal to use (more prone to deadlocks).

* [x]  Remove the  the functions `celix_bundleContext_useService*`  and methods `celix::BundleContext::useService*`  to decrease the code size and improve the maintainability. Also introduce some testing methods to replace the useService with wait timeout usecase for testing.

Simplified the implementation of celix_bundleContext_useService* instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnoltes pnoltes

Labels
component/framework Categorizes an issue or PR relevant to the framework. kind/improvement Categorizes issue or PR as related to improvements.
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@pnoltes @rlenferink