Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining use of deprecated headers in public api #538

Open
PengZheng opened this issue May 4, 2023 · 0 comments · May be fixed by #542
Open

Remove remaining use of deprecated headers in public api #538

PengZheng opened this issue May 4, 2023 · 0 comments · May be fixed by #542
Assignees
@xuzhenbao

Comments

@PengZheng
Copy link
Contributor

celix/bundles/remote_services/rsa_spi/CMakeLists.txt

Lines 20 to 26 in c0666d0

get_target_property(FRAMEWORK_SOURCE_DIR Celix::framework "SOURCE_DIR")
target_include_directories(c_rsa_spi INTERFACE
$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/include>
$<BUILD_INTERFACE:${FRAMEWORK_SOURCE_DIR}/include_deprecated>##TODO remove when deprecated header service_reference.h is removed
)
set_property(TARGET celix-deprecated APPEND PROPERTY "FRAMEWORK_TARGETS" c_rsa_spi)
target_link_libraries(c_rsa_spi INTERFACE Celix::framework)

@xuzhenbao xuzhenbao linked a pull request May 5, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xuzhenbao xuzhenbao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated header for public api xuzhenbao/celix
2 participants
@PengZheng @xuzhenbao