Merge branch 'master' into feature/215-stop-launcher-by-signal

apache · Jun 12, 2024 · 49a5252 · 49a5252
2 parents 8f4fafc + 58860bb
commit 49a5252
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 18 deletions.
diff --git a/bundles/event_admin/event_admin/gtest/src/CelixEventAdminTestSuite.cc b/bundles/event_admin/event_admin/gtest/src/CelixEventAdminTestSuite.cc
@@ -19,6 +19,7 @@
 #include <unistd.h>
 #include <semaphore.h>
 #include <cstdlib>
+#include <future>
 
 #include <gtest/gtest.h>
 #include "CelixEventAdminTestSuiteBaseClass.h"
@@ -605,36 +606,50 @@ TEST_F(CelixEventAdminTestSuite, PostEventWithInvalidArgumentsTest) {
     });
 }
 
-static bool g_blockingHandlerCalled = false;
 TEST_F(CelixEventAdminTestSuite, AsyncEventQueueFullTest) {
-    g_blockingHandlerCalled = true;
-    TestPublishEvent("org/celix/test", nullptr, [](celix_event_admin_t *ea) {
-        for (int i = 0; i < 512 + 1/*handling event*/; ++i) {
+    std::promise<void> promise1;
+    auto future1 = promise1.get_future();
+    std::promise<void> promise2;
+    auto future2 = promise2.get_future();
+    TestPublishEvent("org/celix/test", nullptr, [&promise2, &future1](celix_event_admin_t *ea) {
+        for (int i = 0; i < 512; ++i) {
             auto status = celix_eventAdmin_postEvent(ea, "org/celix/test", nullptr);
             EXPECT_EQ(CELIX_SUCCESS, status);
         }
-        usleep(30000);
+        future1.get();
         auto status = celix_eventAdmin_postEvent(ea, "org/celix/test", nullptr);
+        EXPECT_EQ(CELIX_SUCCESS, status);
+        status = celix_eventAdmin_postEvent(ea, "org/celix/test", nullptr);
         EXPECT_EQ(CELIX_ILLEGAL_STATE, status);
-        g_blockingHandlerCalled = false;
-    }, [](void *handle, const char *topic, const celix_properties_t *props) {
+        promise2.set_value();
+    }, [&promise1, &future2](void *handle, const char *topic, const celix_properties_t *props) {
         (void)handle;
         (void)props;
         (void)topic;
-        while (g_blockingHandlerCalled) usleep(1000);
+        static bool firstCalled{true};
+        if (firstCalled) {
+            promise1.set_value();
+            future2.get();
+            firstCalled = false;
+        }
         return CELIX_SUCCESS;
     });
 }
 
 TEST_F(CelixEventAdminTestSuite, RemoveEventHandlerAfterEventAdminStopTest) {
-    g_blockingHandlerCalled = true;
+    std::promise<void> promise;
+    auto future = promise.get_future();
     celix_event_handler_service_t handler;
-    handler.handle = nullptr;
+    handler.handle = &future;
     handler.handleEvent = [](void *handle, const char *topic, const celix_properties_t *props) {
-        (void)handle;
+        auto feature = static_cast<std::future<void>*>(handle);
         (void)topic;
         (void)props;
-        while (g_blockingHandlerCalled) usleep(1000);
+        static bool firstCalled{true};
+        if (firstCalled) {
+            feature->get();
+            firstCalled = false;
+        }
         return CELIX_SUCCESS;
     };
     auto props = celix_properties_create();
@@ -669,7 +684,7 @@ TEST_F(CelixEventAdminTestSuite, RemoveEventHandlerAfterEventAdminStopTest) {
         EXPECT_EQ(CELIX_SUCCESS, status);
     }
 
-    g_blockingHandlerCalled = false;
+    promise.set_value();
     status = celix_eventAdmin_stop(ea);
     EXPECT_EQ(CELIX_SUCCESS, status);
 

diff --git a/bundles/event_admin/event_admin/gtest/src/CelixEventAdminTestSuiteBaseClass.h b/bundles/event_admin/event_admin/gtest/src/CelixEventAdminTestSuiteBaseClass.h
@@ -20,6 +20,7 @@
 #ifndef CELIX_CELIX_EVENT_ADMIN_TEST_SUITE_BASE_CLASS_H
 #define CELIX_CELIX_EVENT_ADMIN_TEST_SUITE_BASE_CLASS_H
 
+#include <functional>
 
 #include "celix_event_admin.h"
 #include "celix_event_handler_service.h"
@@ -137,16 +138,22 @@ class CelixEventAdminTestSuiteBaseClass : public ::testing::Test {
         celix_eventAdmin_destroy(ea);
     }
 
-    void TestPublishEvent(const char *handlerTopics, const char *eventFilter, void (*testBody)(celix_event_admin_t *ea),
-                          celix_status_t (*onHandleEvent)(void *handle, const char *topic, const celix_properties_t *props), bool asyncUnordered = false) {
+    void TestPublishEvent(const char *handlerTopics, const char *eventFilter, std::function<void(celix_event_admin_t*)> testBody,
+                          std::function<celix_status_t (void*, const char*, const celix_properties_t*)> onHandleEvent, bool asyncUnordered = false) {
         auto ea = celix_eventAdmin_create(ctx.get());
         EXPECT_TRUE(ea != nullptr);
         auto status = celix_eventAdmin_start(ea);
         EXPECT_EQ(CELIX_SUCCESS, status);
-
+        struct celix_handle_event_callback_data {
+                std::function<celix_status_t (void*, const char*, const celix_properties_t*)> onHandleEvent;
+                void* handle;
+        } data{onHandleEvent, ea};
         celix_event_handler_service_t handler;
-        handler.handle = ea;
-        handler.handleEvent = onHandleEvent;
+        handler.handle = &data;
+        handler.handleEvent = [](void *handle, const char *topic, const celix_properties_t *props) {
+            auto data = static_cast<celix_handle_event_callback_data*>(handle);
+            return data->onHandleEvent(data->handle, topic, props);
+        };
         auto props = celix_properties_create();
         celix_properties_set(props, CELIX_FRAMEWORK_SERVICE_VERSION, CELIX_EVENT_HANDLER_SERVICE_VERSION);
         celix_properties_set(props, CELIX_EVENT_TOPIC, handlerTopics);