[CELEBORN-1601][CELEBORN-1697][FOLLOWUP] Refine the RESTful apis for revise lost shuffles and fix ThreadStack REST model #2892
+408
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
turboFei
changed the title
turboFei
changed the title
turboFei
changed the title
|
@turboFei, is there any tool that could verify the consistency between generated openapi-client code and rest api model? |
SteNicholas
reviewed
Nov 7, 2024
...c/main/scala/org/apache/celeborn/service/deploy/master/http/api/v1/ApplicationResource.scala
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Nov 7, 2024
...c/main/scala/org/apache/celeborn/service/deploy/master/http/api/v1/ApplicationResource.scala
Show resolved
Hide resolved
turboFei
force-pushed
the
delete_app
branch
2 times, most recently
from
9630d91
to
5134b9b
Compare
Not yet now, maybe we can followup it to diff the generated RESTful modules in GA. Raised https://issues.apache.org/jira/browse/CELEBORN-1699 to track |
Addressed in #2893 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
GET /api/v1/applications/deleteApps->DELETE /api/v1/applicationsGET /api/v1/applications/reviseLostShuffles->POST /api/v1/applications/revise_lost_shufflesFix the ThreadStack REST model fields
Why are the changes needed?
Followup for #2746 and #2888
Does this PR introduce any user-facing change?
No, these APIs has not been released yet.
How was this patch tested?
GA.