[CELEBORN-1541] Enhance the readable address for internal port #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxzl25
approved these changes
Aug 2, 2024
FMX
approved these changes
Aug 2, 2024
FMX
pushed a commit
that referenced
this pull request
Aug 2, 2024
### What changes were proposed in this pull request? If the internal port is not defined, do not show the internal port(-1) in the readable address. ### Why are the changes needed? If the workerInfo is applied for the RESTful request, such as curl `/api/v1/workers/exclude`, the internal port is always `-1`. It is not necessary to show the `-1` in the readable address. ### Does this PR introduce _any_ user-facing change? Just reduce the unnecessary info. ### How was this patch tested? Not needed. Closes #2659 from turboFei/internal_port. Authored-by: Wang, Fei <[email protected]> Signed-off-by: mingji <[email protected]> (cherry picked from commit dceef47) Signed-off-by: mingji <[email protected]>
wankunde
pushed a commit
to wankunde/celeborn
that referenced
this pull request
Oct 11, 2024
### What changes were proposed in this pull request? If the internal port is not defined, do not show the internal port(-1) in the readable address. ### Why are the changes needed? If the workerInfo is applied for the RESTful request, such as curl `/api/v1/workers/exclude`, the internal port is always `-1`. It is not necessary to show the `-1` in the readable address. ### Does this PR introduce _any_ user-facing change? Just reduce the unnecessary info. ### How was this patch tested? Not needed. Closes apache#2659 from turboFei/internal_port. Authored-by: Wang, Fei <[email protected]> Signed-off-by: mingji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If the internal port is not defined, do not show the internal port(-1) in the readable address.
Why are the changes needed?
If the workerInfo is applied for the RESTful request, such as curl
/api/v1/workers/exclude, the internal port is always-1.It is not necessary to show the
-1in the readable address.Does this PR introduce any user-facing change?
Just reduce the unnecessary info.
How was this patch tested?
Not needed.