Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1467] celeborn.worker.storage.dirs should support soft link #2576

Closed
wants to merge 1 commit into from

Conversation

leixm
Copy link
Contributor

@leixm leixm commented Jun 19, 2024

What changes were proposed in this pull request?

celeborn.worker.storage.dirs supports soft link

Why are the changes needed?

NPE will be thrown when StorageManager.createWriter if celeborn.worker.storage.dirs contains soft link.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing uts.

@leixm
Copy link
Contributor Author

leixm commented Jun 19, 2024

We have a soft link

/mnt/ssd/0 -> /mnt/ssd/3

worker conf

celeborn.worker.storage.dirs                    /mnt/ssd/0,/mnt/ssd/1,/mnt/ssd/2

df -h

/dev/sda3       1.1T  568G  486G   54% /
/dev/sdb        3.5T   92G  3.2T    3% /mnt/ssd/1
/dev/sdc        3.5T  110G  3.2T    4% /mnt/ssd/2
/dev/sdd        3.5T   88G  3.2T    3% /mnt/ssd/3

ls /sys/block/

sda  sdb  sdc  sdd

StorageManager#diskInfos

/mnt/ssd/3=DiskInfo(maxSlots: 0, committed shuffles 0, running applications 0, shuffleAllocations: Map(), mountPoint: /mnt/ssd/3, usableSpace: 0.0 B, avgFlushTime: 0 ns, avgFetchTime: 0 ns, activeSlots: 0, storageType: HDD) status: HEALTHY dirs /mnt/ssd/0/celeborn-worker/shuffle_data

We should keep dirs and mount point consistent, so above dirs should be /mnt/ssd/3/celeborn-worker/shuffle_data

@AngersZhuuuu
Copy link
Contributor

ping @waitinfuture @FMX

Copy link
Contributor

@FMX FMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. After some tests, this PR is correct. Merged into main(v0.6.0), branch-0.5(v0.5.0), branch-0.4(v0.4.2).

Copy link
Contributor

@RexXiong RexXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FMX FMX closed this in 759638e Jun 19, 2024
FMX pushed a commit that referenced this pull request Jun 19, 2024
### What changes were proposed in this pull request?
`celeborn.worker.storage.dirs` supports soft link

### Why are the changes needed?
NPE will be thrown when StorageManager.createWriter if `celeborn.worker.storage.dirs` contains soft link.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Existing uts.

Closes #2576 from leixm/CELEBORN-1467.

Authored-by: Xianming Lei <[email protected]>
Signed-off-by: mingji <[email protected]>
(cherry picked from commit 759638e)
Signed-off-by: mingji <[email protected]>
FMX pushed a commit that referenced this pull request Jun 19, 2024
### What changes were proposed in this pull request?
`celeborn.worker.storage.dirs` supports soft link

### Why are the changes needed?
NPE will be thrown when StorageManager.createWriter if `celeborn.worker.storage.dirs` contains soft link.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Existing uts.

Closes #2576 from leixm/CELEBORN-1467.

Authored-by: Xianming Lei <[email protected]>
Signed-off-by: mingji <[email protected]>
(cherry picked from commit 759638e)
Signed-off-by: mingji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants