Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CELEBORN-999] MR deps check #1928

Closed
wants to merge 7 commits into from
Closed

[CELEBORN-999] MR deps check #1928

wants to merge 7 commits into from

Conversation

cxzl25
Copy link
Contributor

@cxzl25 cxzl25 commented Sep 20, 2023 •
edited
Loading

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

./dev/dependencies.sh  --module mr --check
./dev/dependencies.sh  --module mr --check --sbt

@cxzl25 cxzl25 marked this pull request as draft September 20, 2023 06:19
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #1928 (b1406fd) into main (c4135dc) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head b1406fd differs from pull request most recent head 938459b. Consider uploading reports for the commit 938459b to get more accurate results

@@           Coverage Diff           @@
##             main    #1928   +/-   ##
=======================================
  Coverage   46.96%   46.96%           
=======================================
  Files         164      164           
  Lines       10361    10361           
  Branches      956      956           
=======================================
  Hits         4865     4865           
  Misses       5178     5178           
  Partials      318      318

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cfmcgrady cfmcgrady mentioned this pull request Oct 6, 2023
Closed
cxzl25
cxzl25 commented Oct 9, 2023
View reviewed changes
project/CelebornBuild.scala Outdated
@@ -895,6 +906,8 @@ object MRClientProjects {
.settings(
commonSettings,
libraryDependencies ++= Seq(
Dependencies.commonsCompress,
Dependencies.commonsLogging,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.scala-sbt.org/release/docs/Library-Management.html#Conflict+Management

By default, the latest revision is selected

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a discussion with @pan3793 about how to pin dependency versions, and we ultimately chose the dependencyOverrides approach. see #1831 (comment). cc @pan3793

@cxzl25 cxzl25 marked this pull request as ready for review October 9, 2023 04:55
@waitinfuture
Copy link
Contributor

Hi @FMX , could you take a look at this?

@cfmcgrady
Copy link
Contributor

thanks, merging to main(v0.4.0)

@cfmcgrady cfmcgrady closed this in 6fa6697 Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfmcgrady cfmcgrady cfmcgrady approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cxzl25 @waitinfuture @cfmcgrady