Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-852][FOLLOWUP] Add active connection count metrics to grafana dashboard. #1783

Closed
wants to merge 2 commits into from

Conversation

FMX
Copy link
Contributor

@FMX FMX commented Aug 2, 2023

What changes were proposed in this pull request?

Add active connections count metrics to grafana dashboard.

Why are the changes needed?

Ditto.

Does this PR introduce any user-facing change?

Yes, new metric chart in the grafana dashboard.

How was this patch tested?

Cluster.

@FMX
Copy link
Contributor Author

FMX commented Aug 2, 2023

截屏2023-08-02 11 27 07

@FMX FMX requested a review from waitinfuture August 2, 2023 03:33
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1783 (fe05ea6) into main (3e266c0) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1783      +/-   ##
==========================================
+ Coverage   46.78%   46.80%   +0.02%     
==========================================
  Files         162      162              
  Lines       10012    10012              
  Branches      923      923              
==========================================
+ Hits         4683     4685       +2     
+ Misses       5019     5018       -1     
+ Partials      310      309       -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@waitinfuture waitinfuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Merging to main.

zwangsheng pushed a commit to zwangsheng/RemoteShuffleService that referenced this pull request Aug 4, 2023
…na dashboard

### What changes were proposed in this pull request?
Add active connections count metrics to grafana dashboard.

### Why are the changes needed?
Ditto.

### Does this PR introduce _any_ user-facing change?
Yes, new metric chart in the grafana dashboard.

### How was this patch tested?
Cluster.

Closes apache#1783 from FMX/CELEBORN-852.

Authored-by: mingji <[email protected]>
Signed-off-by: zky.zhoukeyong <[email protected]>
waitinfuture pushed a commit that referenced this pull request Aug 30, 2023
…na dashboard

### What changes were proposed in this pull request?
Add active connections count metrics to grafana dashboard.

### Why are the changes needed?
Ditto.

### Does this PR introduce _any_ user-facing change?
Yes, new metric chart in the grafana dashboard.

### How was this patch tested?
Cluster.

Closes #1783 from FMX/CELEBORN-852.

Authored-by: mingji <[email protected]>
Signed-off-by: zky.zhoukeyong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants