-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAVA-1328: Upgrade guava 16.0.1 -> 20.0 #769
Conversation
Hi @mspangdal, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. Sincerely, |
Thank you @mspangdal for signing the Contribution License Agreement. Cheers, |
d5dbcf9
to
465f772
Compare
SSL failures, not really sure how to interpret the failures though |
Thanks @mspangdal for contributing this, it is very helpful. Unfortunately, we cannot upgrade right now to 20.0 as a lot of people out there are stuck with older versions (especially the devs for the Spark-Cassandra connector). Read JAVA-1328 for more details and please vote for this ticket if you need the upgrade ASAP. |
465f772
to
d34d3e6
Compare
d34d3e6
to
01bb957
Compare
Any progress on this? How would this be affected by the next version of Guava that will be Java 8-only if I have understood it correctly? |
Based on @olim7t's comments in JAVA-1328, there's an approach to support both >= 20 and < 20 versions of guava, but it is not trivial. My opinion is that we don't try to support both simultaneously and make it a requirement for the next major version of the driver to shade guava and reduce the dependency on it (made easier if we require java 8). Of course this depends on the timeline of our next major version and need from the community to have a support path for 20 (please vote on that ticket and add comments if you need it). |
I've opened #784 to explore the idea I suggested on the Jira ticket. It supports both pre- and post-19 versions. |
@mspangdal @olim7t can we close this in favor of #784 ? |
Sure, no problem! |
No description provided.