Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAVA-1328: Upgrade guava 16.0.1 -> 20.0 #769

Closed
wants to merge 1 commit into from

Conversation

mspangdal
Copy link

No description provided.

@datastax-bot
Copy link

Hi @mspangdal, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

Sincerely,
DataStax Bot.

@datastax-bot
Copy link

Thank you @mspangdal for signing the Contribution License Agreement.

Cheers,
DataStax Bot.

@mspangdal mspangdal force-pushed the use-guava-20-for-3.x branch 2 times, most recently from d5dbcf9 to 465f772 Compare November 22, 2016 00:15
@mspangdal
Copy link
Author

SSL failures, not really sure how to interpret the failures though

@adutra
Copy link
Contributor

adutra commented Nov 22, 2016

Thanks @mspangdal for contributing this, it is very helpful. Unfortunately, we cannot upgrade right now to 20.0 as a lot of people out there are stuck with older versions (especially the devs for the Spark-Cassandra connector). Read JAVA-1328 for more details and please vote for this ticket if you need the upgrade ASAP.

@mspangdal mspangdal force-pushed the use-guava-20-for-3.x branch from 465f772 to d34d3e6 Compare November 22, 2016 20:32
@mspangdal mspangdal changed the title Upgrade guava 16.0.1 -> 20.0 JAVA-1328 Upgrade guava 16.0.1 -> 20.0 Nov 22, 2016
@mspangdal mspangdal changed the title JAVA-1328 Upgrade guava 16.0.1 -> 20.0 JAVA-1328: Upgrade guava 16.0.1 -> 20.0 Nov 22, 2016
@mspangdal mspangdal force-pushed the use-guava-20-for-3.x branch from d34d3e6 to 01bb957 Compare November 22, 2016 21:48
@dn-mib
Copy link

dn-mib commented Jan 5, 2017

Any progress on this? How would this be affected by the next version of Guava that will be Java 8-only if I have understood it correctly?

@tolbertam
Copy link
Contributor

tolbertam commented Jan 6, 2017

Any progress on this? How would this be affected by the next version of Guava that will be Java 8-only if I have understood it correctly?

Based on @olim7t's comments in JAVA-1328, there's an approach to support both >= 20 and < 20 versions of guava, but it is not trivial. My opinion is that we don't try to support both simultaneously and make it a requirement for the next major version of the driver to shade guava and reduce the dependency on it (made easier if we require java 8). Of course this depends on the timeline of our next major version and need from the community to have a support path for 20 (please vote on that ticket and add comments if you need it).

@olim7t olim7t mentioned this pull request Jan 10, 2017
@olim7t
Copy link
Contributor

olim7t commented Jan 11, 2017

I've opened #784 to explore the idea I suggested on the Jira ticket. It supports both pre- and post-19 versions.
Sorry for creating a separate PR, but I wanted to base it on 3.0.x.

@adutra
Copy link
Contributor

adutra commented Feb 8, 2017

@mspangdal @olim7t can we close this in favor of #784 ?

@mspangdal
Copy link
Author

Sure, no problem!

@mspangdal mspangdal closed this Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants