CASSJAVA-54 Update Cassandra/DSE/Java versions in DataStax Jenkinsfile #1984
+6
−60
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -274,12 +274,8 @@ pipeline { | |
| '3.11', // Previous Apache CassandraⓇ | ||
| '4.0', // Previous Apache CassandraⓇ | ||
| '4.1', // Current Apache CassandraⓇ | ||
| '5.0', // Development Apache CassandraⓇ | ||
| 'dse-5.1.35', // Legacy DataStax Enterprise | ||
| 'dse-6.8.30', // Current DataStax Enterprise | ||
| 'dse-6.9.0', // Current DataStax Enterprise | ||
| 'hcd-1.0.0', // Current DataStax HCD | ||
|
|
@@ -292,14 +288,6 @@ pipeline { | |
| <th align="left">Choice</th> | ||
| <th align="left">Description</th> | ||
| </tr> | ||
|
There was a problem hiding this comment. According to the driver readme we should also be supporting these as well but (a) they're also EOL (and thus prolly excluded based on the logic above) and (b) the ASF CI is canonical for these versions. |
||
| <tr> | ||
| <td><strong>3.0</strong></td> | ||
| <td>Apache Cassandra® v3.0.x</td> | ||
|
|
@@ -316,26 +304,10 @@ pipeline { | |
| <td><strong>4.1</strong></td> | ||
| <td>Apache Cassandra® v4.1.x</td> | ||
| </tr> | ||
| <tr> | ||
| <td><strong>dse-5.1.35</strong></td> | ||
| <td>DataStax Enterprise v5.1.x</td> | ||
| </tr> | ||
| <tr> | ||
| <td><strong>dse-6.8.30</strong></td> | ||
| <td>DataStax Enterprise v6.8.x</td> | ||
|
|
@@ -371,30 +343,10 @@ pipeline { | |
| <td><strong>1.8</strong></td> | ||
| <td>Oracle JDK version 1.8 (<i>Used for compiling regardless of choice</i>)</td> | ||
| </tr> | ||
| <tr> | ||
| <td><strong>[email protected]</strong></td> | ||
| <td>OpenJDK version 11</td> | ||
| </tr> | ||
|
There was a problem hiding this comment. Non-LTS versions which are already EOL. We also aren't aiming to explicitly support anything that isn't an LTS Java release so in the interest of keeping this simple I just yanked all of these. |
||
| <tr> | ||
| <td><strong>[email protected]</strong></td> | ||
| <td>OpenJDK version 17</td> | ||
|
|
@@ -434,14 +386,12 @@ pipeline { | |
| triggers { | ||
| // schedules only run against release branches (i.e. 3.x, 4.x, 4.5.x, etc.) | ||
| parameterizedCron(branchPatternCron().matcher(env.BRANCH_NAME).matches() ? """ | ||
| # All tests below should run against a common collection of backend servers | ||
| # Every weekend (Saturday, Sunday) around 2:00 AM | ||
| H 2 * * 0 %CI_SCHEDULE=WEEKENDS;CI_SCHEDULE_SERVER_VERSIONS=3.11 4.1 5.0 dse-6.8.30 dse-6.9.0 hcd-1.0.0;CI_SCHEDULE_JABBA_VERSION=1.8 | ||
| # Every weeknight (Monday - Friday) around 12:00 PM noon | ||
| H 12 * * 1-5 %CI_SCHEDULE=WEEKNIGHTS;CI_SCHEDULE_SERVER_VERSIONS=3.11 4.1 5.0 dse-6.8.30 dse-6.9.0 hcd-1.0.0;[email protected] | ||
| H 12 * * 1-5 %CI_SCHEDULE=WEEKNIGHTS;CI_SCHEDULE_SERVER_VERSIONS=3.11 4.1 5.0 dse-6.8.30 dse-6.9.0 hcd-1.0.0;[email protected] | ||
| """ : "") | ||
| } | ||
|
|
||
|
|
@@ -590,12 +540,8 @@ pipeline { | |
| '3.11', // Previous Apache CassandraⓇ | ||
| '4.0', // Previous Apache CassandraⓇ | ||
| '4.1', // Current Apache CassandraⓇ | ||
| '5.0', // Development Apache CassandraⓇ | ||
| 'dse-5.1.35', // Legacy DataStax Enterprise | ||
| 'dse-6.8.30', // Current DataStax Enterprise | ||
| 'dse-6.9.0', // Current DataStax Enterprise | ||
| 'hcd-1.0.0' // Current DataStax HCD | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be too aggressive. The top-level readme for the driver says that we support C* 2.1 and up as well as DSE 4.8.x and up. The four releases above are now EOL and we did decide that we were going to follow the DataStax drivers policy of only supporting releases that weren't EOL at time of release... so I decided to yank these.
At a minimum we should probably update the readme to be clearer about our policy if we choose to move forward with these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we do not need to explicitly mention policy, but update versions in README would be enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alternative that I'm considering is that we can just update 5.0 and remove the EOL Apache Cassandra versions now. Apache C* is properly covered by the ASF CI and this is just a "backup" for that.... and if we're just testing EOL versions that should be adequate. Neither of those changes require an update to the support policy.
We can change the DSE versions later after we have some consensus around the approach the project will take re: backend support.