-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAMEL-12079: Bean language: support bean::function notation #2156
Conversation
Looks good, but not sure if we want to add other stuff to the bean language. @davsclaus WDYT? |
I just took the ticket from JIRA. If not needed, I can close the PR. |
yeah, my fault. Too much tickets I'm looking at :-) |
I'll merge tomorrow :-) Thanks for the PR. |
Feel free to wait comments etc. |
Specifying a method name on a bean is used in a few other places as well. Just search the code for similar pattern I think we should also get input from @lburgazzoli so lets wait till he get back from PTO |
If there are other places where the . notation is used we should update that too |
if (doubleColonIndex > 0) { | ||
beanName = expression.substring(0, doubleColonIndex); | ||
method = expression.substring(doubleColonIndex + 2); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check first for ::`` then for
.otherwise expressions like
my.own.Bean::function` would lead to error
@snurmine do you have any time to complete this PR ? |
I try after vacation 8.2 |
a4195b8
to
693c4e8
Compare
Tried to fix issues. Not sure tough if found every place (I search using ?method=) |
@lburgazzoli can you review? This looks good to me. |
@snurmine it looks good to me, the only additional think I'd like to have is a test that validate method resolution for cases like "my.company.MyClass::method" |
We need to check for
Also a little bit of a 3rd party problem is that Camel tooling need to be aware of this and also add support for checking the double colon syntax as well - but that should be possible. We need to add this to the release note of this change. Also we need to educate Camel users that the
|
Added more test cases to BeanTest. ResourceHelper delegates parsing to BeanLanguage now. |
[ENTESB-20648] Upgrade to Spring Boot 2.7.9, Spring Batch 4.3.8 and S…
No description provided.