Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark modules using legacy @ConfigRoot as such #6331

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

gsmet
Copy link
Contributor

@gsmet gsmet commented Aug 8, 2024

The new extension annotation processor coming with 3.14 requires that you mark the modules using the legacy @configroot approach (i.e. without @ConfigMapping) with a specific annotation processor parameter.

This is important for the generation of the config documentation (which is enabled by default).

This can be merged pre-3.14 update but will result in a warning when building. With the advantage of having the build with main passing.

I think I have marked all of them but in any case, if you have an error, you now know what to do.

Fixes quarkusio/quarkus#42417

The new extension annotation processor coming with 3.14 requires that
you mark the modules using the legacy @configroot approach (i.e.
without @ConfigMapping) with a specific annotation processor parameter.

This is important for the generation of the config documentation (which
is enabled by default).

This can be merged pre-3.14 update but will result in a warning when
building. With the advantage of having the build with main passing.
@gsmet
Copy link
Contributor Author

gsmet commented Aug 8, 2024

At your disposal if you have any questions about this change!

@gsmet
Copy link
Contributor Author

gsmet commented Aug 8, 2024

I added more details here: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.14#for-extension-developers

Note that by applying just this patch, you will get a warning when compiling the test classes (as given you don't have a config annotation, the annotation processor will not be triggered and you will get a warning telling you the parameter is unused).
Ideally, you would adjust to only run the annotation processor for the main classes as described in the doc but I didn't want to be too aggressive on your codebase :).
Feel free to do it if you think it makes sense.

@jamesnetherton
Copy link
Contributor

Thanks @gsmet!

I can follow up with any additional tweaks.

@jamesnetherton jamesnetherton merged commit 93e8ffb into apache:main Aug 9, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config Doc - Adjust Camel Quarkus annotation processor config
2 participants