Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the Camel Quarkus version on startup #6216

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

jamesnetherton
Copy link
Contributor

I opened this in draft to get some feedback.

For micro release of Quarkus, we may end with something like this in the console logs:

INFO  [org.apa.cam.qua.cor.CamelBootstrapRecorder] (main) Apache Camel Quarkus 3.12.0 is starting
...
INFO  [io.quarkus] (main) my-cool-app 1.0.0 on JVM (powered by Quarkus 3.12.3)

Do folks think this could be a source of confusion for users? That the CQ version is potentially out of alignment compared to the version of the platform BOM.

@zbendhiba
Copy link
Contributor

@jamesnetherton The PR alignes the Camel Quarkus version to minor quarkus platform version, is that correct?

@jamesnetherton
Copy link
Contributor Author

The PR alignes the Camel Quarkus version to minor quarkus platform version, is that correct?

The CQ version displayed in the logs will just be whatever the platform is aligned with. So it may not match the platform version perfectly.

@zhfeng
Copy link
Contributor

zhfeng commented Jun 21, 2024

Well, I doubt that this could confuse tht users, there are camel version and quarkus version, now camel-quarkus version. How about show all of these version one line?

(main) Apache Camel Quarkus 3.12.0 (based on Camel 4.6.0 and Quarkus 3.12.0) is starting

@aldettinger
Copy link
Contributor

aldettinger commented Jun 21, 2024

👍 for the proposal from @zhfeng.

@jamesnetherton
Copy link
Contributor Author

Thanks for the feedback all. Seems the general idea is acceptable.

I'll stick with my original proposal of Apache Camel Quarkus 3.12.0 is starting initially. We can always revisit and update it in future.

@jamesnetherton jamesnetherton marked this pull request as ready for review July 8, 2024 13:28
@jamesnetherton jamesnetherton merged commit c581f84 into apache:main Jul 8, 2024
24 checks passed
@jamesnetherton jamesnetherton deleted the log-cq-version branch July 8, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants