-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test support certicate #6116
Test support certicate #6116
Conversation
4fc5634
to
889ad52
Compare
311ec6e
to
0a73f9d
Compare
0a73f9d
to
2f3a3ca
Compare
Thanks a lot for this @JiriOndrusek! Please can you check this can work in the quarkus-platform. I tested a few things (mail & kafka) and they passed. But paho and paho-mqtt5 were failing for me with a remote docker host, due to certificate validation errors.
|
Thank for finding that! This is just oversight on my side. I refactored away |
2f3a3ca
to
2949c61
Compare
I'll check again all affected tests
|
@jamesnetherton the first 2 "groups" were successful.
|
I checked and they all passed 👍 So I guess we're good to merge this? |
Yes, we are good. |
fixes #5967
fixes #6125
fixes #6126
fixes #6127
PR refactors following modules to use test-support-certificate-generator:
for cxf-soap and ldap no change is provided. The certificate-generator project does not allow to customize such high details of certificate generation. Detailed explanation can be seen in the comment.