-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(native): support Native Sources #5380
Conversation
Required to enable Native Sources compilation - https://quarkus.io/guides/building-native-image#separating-java-and-native-image-compilation
...ployment/src/main/java/org/apache/camel/quarkus/component/asn1/deployment/Asn1Processor.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing the involved build steps, it should work with native or native sources.
Worst case, this pr make it possible to experiment and refine.
Plus it is a good moment from release stream point of view to include such a change.
Thanks folks. Are we good to merge it then? I'd like to have this in the next release so I can follow up the work on Camel K side. |
@squakez So with less coupling between Camel K and the runtime, this pr targets Camel Quarkus 3.5.x only ? @jamesnetherton @ppalaga Please raise a hand in case there is any blocker to merge this. |
@aldettinger I'd be good with any version you're willing to release next. |
Syncing on this from side discussion, let's better merge in main to target 3.5.x. |
With this PR we enable Native Sources compilation - https://quarkus.io/guides/building-native-image#separating-java-and-native-image-compilation
This is going to be fully compatible with canonical native as it uses the Quarkus suggested way of checking native build step: https://github.com/quarkusio/quarkus/blob/main/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeOrNativeSourcesBuild.java