Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MapStruct native support #5123

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Add MapStruct native support #5123

merged 1 commit into from
Jul 27, 2023

Conversation

jamesnetherton
Copy link
Contributor

No description provided.

@aldettinger
Copy link
Contributor

From what I understand, config camel.component.mapstruct.mapStructConverter is not special enough to deserve a CQ test.

This extension really take advantage of build time augmentation, nice job @jamesnetherton 👍

aldettinger
aldettinger approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nitpick if time, beyond it's good.

@jamesnetherton
Copy link
Contributor Author

Thanks @aldettinger. Latest commit should address your review comments.

@jamesnetherton jamesnetherton merged commit 0159a89 into apache:main Jul 27, 2023
@jamesnetherton jamesnetherton deleted the mapstruct-native branch July 28, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldettinger aldettinger aldettinger approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesnetherton @aldettinger @oscerd