Ref #4220: Add the camel-swift extension #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proposed as a draft for now, because first, it requires Camel 3.20 and it raises a potential bug in Quarkus. |
|
The related bug in Quarkus quarkusio/quarkus#29693 |
essobedo
force-pushed
the
4220/camel-swift-extension
branch
3 times, most recently
from
31b9478 to
a7b9531
Compare
essobedo
force-pushed
the
4220/camel-swift-extension
branch
from
a7b9531 to
f001087
Compare
|
The bug in Quarkus is finally fixed but in Quarkus 3 which requires the Jakarta migration and unfortunately, the swift library has not been migrated yet so this PR is blocked |
Do you, by any chance, have an issue or PR ref. that is blocking this PR? |
|
Blocked by prowide/prowide-iso20022#56 |
We are working on it at Prowide, the beta release should be published soon, within one or two weeks. |
|
@zubri great news thanks for sharing |
essobedo
force-pushed
the
4220/camel-swift-extension
branch
from
f001087 to
cad69b5
Compare
essobedo
force-pushed
the
4220/camel-swift-extension
branch
2 times, most recently
from
0221c3e to
a3c3f8d
Compare
|
NB: The examples are failing but it is not related to those changes since it also fails on the camel-main branch. |
|
Any remarks/suggestions before I merge it? |
integration-tests/swift/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...on-tests/swift/src/test/java/org/apache/camel/quarkus/component/swift/mt/it/SwiftMtTest.java
Outdated
Show resolved
Hide resolved
essobedo
force-pushed
the
4220/camel-swift-extension
branch
from
a3c3f8d to
7824605
Compare
|
@jamesnetherton thx for your feedback, I think I addressed all your remarks |
essobedo
force-pushed
the
4220/camel-swift-extension
branch
from
7824605 to
16e2bfc
Compare
jamesnetherton
approved these changes
Jun 7, 2023
essobedo
force-pushed
the
4220/camel-swift-extension
branch
from
16e2bfc to
dafa56e
Compare
ppalaga
reviewed
Jun 7, 2023
ppalaga
reviewed
Jun 7, 2023
essobedo
force-pushed
the
4220/camel-swift-extension
branch
from
dafa56e to
b68bf59
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
## Motivation There is a new component (dataformat) called `camel-swift` that we would like to add to the project. ## Modifications: * Creates the new extension thanks to the maven plugin * Adds support of the JVM mode for both types of messages (MX and MT) * Adds support of the native mode to MT messages only because MX messages bring too many classes, methods, and fields to access by reflection which slows down the native image build
JiriOndrusek
pushed a commit
that referenced
this pull request
Jun 15, 2023
## Motivation There is a new component (dataformat) called `camel-swift` that we would like to add to the project. ## Modifications: * Creates the new extension thanks to the maven plugin * Adds support of the JVM mode for both types of messages (MX and MT) * Adds support of the native mode to MT messages only because MX messages bring too many classes, methods, and fields to access by reflection which slows down the native image build
JiriOndrusek
pushed a commit
that referenced
this pull request
Jun 20, 2023
## Motivation There is a new component (dataformat) called `camel-swift` that we would like to add to the project. ## Modifications: * Creates the new extension thanks to the maven plugin * Adds support of the JVM mode for both types of messages (MX and MT) * Adds support of the native mode to MT messages only because MX messages bring too many classes, methods, and fields to access by reflection which slows down the native image build
JiriOndrusek
pushed a commit
to JiriOndrusek/camel-quarkus
that referenced
this pull request
Jun 27, 2023
## Motivation There is a new component (dataformat) called `camel-swift` that we would like to add to the project. ## Modifications: * Creates the new extension thanks to the maven plugin * Adds support of the JVM mode for both types of messages (MX and MT) * Adds support of the native mode to MT messages only because MX messages bring too many classes, methods, and fields to access by reflection which slows down the native image build
JiriOndrusek
pushed a commit
that referenced
this pull request
Jun 27, 2023
## Motivation There is a new component (dataformat) called `camel-swift` that we would like to add to the project. ## Modifications: * Creates the new extension thanks to the maven plugin * Adds support of the JVM mode for both types of messages (MX and MT) * Adds support of the native mode to MT messages only because MX messages bring too many classes, methods, and fields to access by reflection which slows down the native image build
JiriOndrusek
pushed a commit
to JiriOndrusek/camel-quarkus
that referenced
this pull request
Jun 30, 2023
## Motivation There is a new component (dataformat) called `camel-swift` that we would like to add to the project. ## Modifications: * Creates the new extension thanks to the maven plugin * Adds support of the JVM mode for both types of messages (MX and MT) * Adds support of the native mode to MT messages only because MX messages bring too many classes, methods, and fields to access by reflection which slows down the native image build
JiriOndrusek
pushed a commit
to JiriOndrusek/camel-quarkus
that referenced
this pull request
Jun 30, 2023
## Motivation There is a new component (dataformat) called `camel-swift` that we would like to add to the project. ## Modifications: * Creates the new extension thanks to the maven plugin * Adds support of the JVM mode for both types of messages (MX and MT) * Adds support of the native mode to MT messages only because MX messages bring too many classes, methods, and fields to access by reflection which slows down the native image build
JiriOndrusek
pushed a commit
to JiriOndrusek/camel-quarkus
that referenced
this pull request
Jun 30, 2023
## Motivation There is a new component (dataformat) called `camel-swift` that we would like to add to the project. ## Modifications: * Creates the new extension thanks to the maven plugin * Adds support of the JVM mode for both types of messages (MX and MT) * Adds support of the native mode to MT messages only because MX messages bring too many classes, methods, and fields to access by reflection which slows down the native image build
JiriOndrusek
pushed a commit
to JiriOndrusek/camel-quarkus
that referenced
this pull request
Jul 3, 2023
## Motivation There is a new component (dataformat) called `camel-swift` that we would like to add to the project. ## Modifications: * Creates the new extension thanks to the maven plugin * Adds support of the JVM mode for both types of messages (MX and MT) * Adds support of the native mode to MT messages only because MX messages bring too many classes, methods, and fields to access by reflection which slows down the native image build
jamesnetherton
pushed a commit
that referenced
this pull request
Jul 3, 2023
## Motivation There is a new component (dataformat) called `camel-swift` that we would like to add to the project. ## Modifications: * Creates the new extension thanks to the maven plugin * Adds support of the JVM mode for both types of messages (MX and MT) * Adds support of the native mode to MT messages only because MX messages bring too many classes, methods, and fields to access by reflection which slows down the native image build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4220
Motivation
There is a new component (dataformat) called
camel-swiftthat we would like to add to the project.Modifications: