Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue/2733 : Native support for kamelet.yaml discovery #2799

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

valdar
Copy link
Member

@valdar valdar commented Jun 16, 2021

  • An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes: Native support for kamelet.yaml discovery #2733
  • Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
  • The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
  • Phrases like Fix # or Fixes # will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
  • Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
  • Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html

Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find above 2 non blocking questions time permitting.
Looks good to me, well done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants