-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nitrite native support #1298 #2254
Conversation
2a72456
to
48b8e3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions inline.
...nt/src/main/java/org/apache/camel/quarkus/component/nitrite/deployment/NitriteProcessor.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/org/apache/camel/quarkus/component/nitrite/deployment/NitriteProcessor.java
Outdated
Show resolved
Hide resolved
...sts/nitrite/src/main/java/org/apache/camel/quarkus/component/nitrite/it/NitriteResource.java
Outdated
Show resolved
Hide resolved
...n-tests/nitrite/src/test/java/org/apache/camel/quarkus/component/nitrite/it/NitriteTest.java
Outdated
Show resolved
Hide resolved
...n-tests/nitrite/src/test/java/org/apache/camel/quarkus/component/nitrite/it/NitriteTest.java
Outdated
Show resolved
Hide resolved
...sts/nitrite/src/main/java/org/apache/camel/quarkus/component/nitrite/it/NitriteResource.java
Show resolved
Hide resolved
...sts/nitrite/src/main/java/org/apache/camel/quarkus/component/nitrite/it/NitriteResource.java
Outdated
Show resolved
Hide resolved
extensions/nitrite/runtime/src/main/resources/META-INF/native-image/serialization-config.json
Show resolved
Hide resolved
42c8d44
to
1e75bdd
Compare
@JiriOndrusek could you please check the test failures? |
@ppalaga I'll look into it |
@ppalaga Failures will go away, once we switch quarkus to 1.13 (requires change quarkusio/quarkus#15043) |
1e75bdd
to
2e187a8
Compare
Last comment is wrong, test should succeed also in 1.12.final. I've fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @JiriOndrusek Finger crossed that the build issue is easy to get fixed :)
@JiriOndrusek could you please rebase and re-target at quarkus-master branch so that we do not merge to master by any chance before we have Quarkus 1.13? |
OK, I was able to change the base branch from master to quarkus-master myself. Please rebase and change to native-since: 1.8.0 |
@ppalaga I'll look into it |
ee10ff0
to
64b07c7
Compare
@ppalaga I've probably caused misunderstanding with my last comment (so it probably wasn't seen) |
2e187a8
to
5fb3851
Compare
I'll fix current failures. I wrongly solved conflicts. |
Yes, that's right. I was not aware that your fix is available in Quarkus 1.12 too. Sorry for the confusion from my side. |
5fb3851
to
e4c2e8f
Compare
God to merge. |
fixes #1298
requires quarkus 1.13 (requires change quarkusio/quarkus#15043)
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix # or Fixes # will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html