-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(trait): add support for multiple ingress paths #5996
base: main
Are you sure you want to change the base?
Conversation
✔️ Unit test coverage report - coverage increased from 47.2% to 47.3% (+0.1%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff, thanks! As mentioned in the issue, to avoid breaking compatibility you can keep the path
logic and additionally include a paths
with the logic you're willing to implement.
23532bd
to
8d2f4f5
Compare
@squakez - I've now added
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks! If you can give another shot and add a deprecation warning notice in the Integration condition it would be great.
I forgot to add a link to some example you can use for the warning notice: Line 96 in 023e658
|
Excellent - thank you for the example. I'll work to get this added in the coming days. |
Related to issue #5981.
Determine if the IngressTrait should be migrated towards adopting K8s API IngressSpec hierarchy.Can be reviewed again at a later point in time/in a separate PR.
Example usage:
... generates:
Output of ingress (
kubectl get ingress multi-path -o yaml
):Curl Output: