-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(trait): use a configmap index #5948
Conversation
fyi @hernanDatgDev I've tested this against your reproducer and it seems the root issue is fixed. Please, have a look. |
@squakez I pulled your fork and built the project locally. For some reason I'm getting a rest dsl plugin failure when my integration is building.
For reference here's the api spec I'm including in my referenced configmap:
|
Hi @hernanDatgDev, please, let's stick to the original reproducer reported in #5924 (comment) to avoid mixing up things. I've removed the response content and I manage to reproduce your same problem with runtime 3.15.0 (Camel core 4.8.0). However, this is a different problem from the one we're fixing in this PR. I've run the same reproducer against runtime 3.8.1 and the issue is not appearing, so, there is some regression or new behavior introduced in the new Camel core 4.8.0. From Camel K perspective we can't really do anything until that is fixed in the core unfortunately. I suggest you please open an issue and report this in the core. It also may be a core fix, given that we may expect a response to always provide a content, but I am not into openapi spec details to confirm that. As for this PR, please, feel free to have a look and verify if the original issue is solved, so I can merge accordingly. |
It could be caused by the removal of a swagger validator [1] or even the upgrade of swagger dependencies which may be adding now some validation to avoid such value to be empty. https://camel.apache.org/manual/camel-4x-upgrade-guide-4_6.html#_camel_rest_openapi |
@squakez Yes you're right there is some additional validation on the openapi spec and it expects certain parts to be present. I made the necessary changes and got the expected behavior. I also got the expected behavior with the original files I provided in my ticket. The changes made seem good to me so far 👍 |
Closes #5924
Release Note