feat(trait): operate via default catalog #5798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should allow the consume of sources and meta from trait package only via consumer funcs. In this way we can control the logic for instance, allowing to consume only when sources or catalog are available.
With this refactoring, we allow any trait to be executed with at least a default CamelCatalog. This is useful when we run sourceless where, from now on, we can pick the catalog used to operate, regardless if it's a managed Integration or not.
The default is to have a CamelCatalog, so, there is no need to skip traits any longer
|
FYI @hernanDatgDev - although the development should be fully compatible with what we have now, I think it would be nice for you to have a look and confirm if this change would break anything by any chance. |
|
✔️ Unit test coverage report - coverage increased from 43.1% to 43.4% (+0.3%) |
gansheer
approved these changes
Aug 26, 2024
|
@squakez Sure thing. I don't mind testing at all |
If it's easier to test the nightly artifact, I can merge and then you can start your tests from the nightly. Just let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should remove any problem when running any trait in "sourceless" mode. From now on we will adopt the default Camel catalog coming from the platform.
Release Note