fix(traits): annotations refactoring #5637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Pipe transform the annotations into .integration.spec.traits instead of transferring to Integration annotations. This should bring consistency as the Integration would manage the copy to IntegrationKit according its internal logic which is already available. Closes apache#5620
oscerd
approved these changes
Jun 14, 2024
The previous development was flawed, as it did not do the proper comparison with the configuration coming from annotation to the configuration coming from trait spec. This commit is supporting the comparison in a proper manner, however, we're deprecating the feature from other resources which are not Pipe as it does not make sense to support. Ref apache#5620
gansheer
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing #5620 and it's adding the proper support to compare traits coming from the spec with specs coming from the annotations. With the PR, the Pipe is in charge to transform the annotations into
.spec.traitsdirectly, in order to let the Integration to know what to do with them (ie, transferring to the Kit only those that it knows they must be transferred).Beside that, I've introduced a deprecation notice for supporting trait annotations in Integration, IntegrationKit and IntegrationPlatform as it does not make sense to support both configurations. They will be removed in future versions.
As specified in the code comment, the introduction of certain signature functions change is required to properly support the feature (although deprecated) and will be changed back when we will remove the support for this feature.
Closes #5620
Release Note