(#5490) Move deprecated v1alpha1.KameletBinding tests to v1.Pipe #5624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squakez
reviewed
Jun 12, 2024
There was a problem hiding this comment.
I think the correct rename would be pipe-broker instead of kamelet-pipe-broker
There was a problem hiding this comment.
I believe dirs and feature files starting with 'kamlet-binding-...' did so, because they use Kamlet + KamletBinding. Similarly, now we have kamlet-pipe-.... I don't have a strong opinion about naming these. Perhaps @christophd likes to have a particular naming scheme?
Renaming is trivial, there are no references anywhere else.
|
Failed unrelated in ... |
tdiesler
changed the title
|
Failed unrelated in ... |
|
Ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - Please don't merge just yet