-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(install): simplify kustomize procedure #5610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very good first simplified version !
I put some comments on the commands I tested for a global kubernetes installation.
Another thing to report is that on
The rolebindings from I remember when I stumbled on it that there is some kind of hack from kustomize code that make it replace with the given namespace if the value in the yaml is Also you might break the CLI installation if make some changes in these files. |
Yeah, I've noticed that at well, the change will be included with next commit. I think those values where required and replaced by the make UI that was developed on top of Kustomize and which this PR is removing. |
5aa2713
to
29434ee
Compare
This PR aims to provide a simplified approach to the Kustomize. Thanks (to @gansheer) to the work done so far to identify exactly all resources during installation, it is now relatively easy to create a base and an overlay directory that we can use as a base for any user to extend according to their specific needs. This is also quite easy as it provides a set of sensible configuration we can use in our test or documentation.
We can remove the
make
which was an attempt to provide a ui on top of something that is probably thought to be customized on source directly by the final users.If this gets merged, we can work on additional overlays (ie, openshift) as a follow up activity.
Closes #4528
Release Note