Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): simplify kustomize procedure #5610

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Jun 10, 2024

This PR aims to provide a simplified approach to the Kustomize. Thanks (to @gansheer) to the work done so far to identify exactly all resources during installation, it is now relatively easy to create a base and an overlay directory that we can use as a base for any user to extend according to their specific needs. This is also quite easy as it provides a set of sensible configuration we can use in our test or documentation.

We can remove the make which was an attempt to provide a ui on top of something that is probably thought to be customized on source directly by the final users.

If this gets merged, we can work on additional overlays (ie, openshift) as a follow up activity.

Closes #4528

Release Note

fix(install): simplify kustomize procedure

@squakez squakez requested a review from gansheer June 10, 2024 15:16
Copy link
Contributor

@gansheer gansheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good first simplified version !
I put some comments on the commands I tested for a global kubernetes installation.

@squakez squakez linked an issue Jun 11, 2024 that may be closed by this pull request
@squakez squakez requested a review from gansheer June 11, 2024 10:14
@gansheer
Copy link
Contributor

gansheer commented Jun 11, 2024

Another thing to report is that on descoped installation the rolebindings referenced directly on camel-k/install/base/config/rbac/kustomization.yaml still contains placeholder value :

subjects:
- kind: ServiceAccount
  name: camel-k-operator
  namespace: placeholder

The rolebindings from camel-k/install/base/config/rbac/descoped/kustomization.yaml are good since you removed the namespace: placeholder line in the subjects declaration.

I remember when I stumbled on it that there is some kind of hack from kustomize code that make it replace with the given namespace if the value in the yaml is default.

Also you might break the CLI installation if make some changes in these files.

@squakez
Copy link
Contributor Author

squakez commented Jun 12, 2024

Another thing to report is that on descoped installation the rolebindings referenced directly on camel-k/install/base/config/rbac/kustomization.yaml still contains placeholder value :

Yeah, I've noticed that at well, the change will be included with next commit. I think those values where required and replaced by the make UI that was developed on top of Kustomize and which this PR is removing.

@squakez squakez force-pushed the chore/kustomize branch 9 times, most recently from 5aa2713 to 29434ee Compare June 13, 2024 08:28
@squakez squakez merged commit 31fe95d into apache:main Jun 13, 2024
13 checks passed
@squakez squakez deleted the chore/kustomize branch June 13, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kustomize installation does not work Kustomize default
3 participants