Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trait): remove imageWasKit #5418

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix(trait): remove imageWasKit #5418

merged 1 commit into from
Apr 25, 2024

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Apr 24, 2024

As discussed in #5399 we need to clarify the intent of each IntegrationKit types.

  • removal of imageWasKit
  • usage of external IntegrationKit when we are certain that the image comes from an IK
  • usage of syntetic IntegrationKit when the image are coming from any container image
  • rework of promote command to clone an external IntegrationKit beside the Integration and use it accordingly.

Closes #5407

With this PR we'll have the following kit types:

NAME                       ALIAS   PHASE   TYPE        LAYOUT     IMAGE                                                                                                                            ROOT
kit-cokcvlbup5os73dn1skg           Ready   platform    fast-jar   10.100.107.57/default/camel-k-kit-cokcvlbup5os73dn1skg@sha256:150ec29daefe7c9a82f4f35549a68bc88a5347abaf71a1b25792d957d41c0e6d   eclipse-temurin:17
kit-cokcvlbup5os73dn1skg           Ready   external   fast-jar   10.100.107.57/default/camel-k-kit-cokcvlbup5os73dn1skg@sha256:150ec29daefe7c9a82f4f35549a68bc88a5347abaf71a1b25792d957d41c0e6d   
kit-my-camel-main-v1               Ready   synthetic              docker.io/squakez/my-camel-main:1.0.0                                                                                            

The attached documentation should clarify how to use each type.

Release Note

fix(trait): remove imageWasKit

As discussed in apache#5399 we need to clarify the intent of each IntegrationKit types.

* removal of imageWasKit
* usage of external IntegrationKit when we are certain that the image comes from an IK
* usage of syntetic IntegrationKit when the image are coming from any container image
* rework of promote command to clone an external IntegrationKit beside the Integration and use it accordingly.

Closes apache#5408
@squakez squakez merged commit 73c4382 into apache:main Apr 25, 2024
15 checks passed
@squakez squakez deleted the fix/5407 branch April 25, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove container.imageWasKit
3 participants