Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trait): inherit platform configuration #5383

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix(trait): inherit platform configuration #5383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pkg/trait/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ func (t *builderTrait) Configure(e *Environment) (bool, *TraitCondition, error)
condition = newOrAppend(condition, "Spectrum publishing strategy is deprecated and may be removed in future releases. Make sure to use any supported publishing strategy instead.")
}

t.setPlatform(e)

if e.IntegrationKitInPhase(v1.IntegrationKitPhaseBuildSubmitted) {
if trait := e.Catalog.GetTrait(quarkusTraitID); trait != nil {
quarkus, ok := trait.(*quarkusTrait)
Expand Down Expand Up @@ -630,3 +632,12 @@ func publishingOrUserTask(t v1.Task) bool {

return false
}

// Will set a default platform if either specified in the trait or the platform/profile configuration.
func (t *builderTrait) setPlatform(e *Environment) {
if t.ImagePlatforms == nil {
if e.Platform != nil && e.Platform.Status.Build.BuildConfiguration.ImagePlatforms != nil {
t.ImagePlatforms = e.Platform.Status.Build.BuildConfiguration.ImagePlatforms
}
}
}
Loading