chore: re-enable file permissions test on darwin #5380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Apr 17, 2024
|
There is another such test, which now works too Perhaps you'd like to remove those build tags there as well |
squakez
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
the
TestPermissionDeniedwas disabled on Darwin because it was accessing/rootwhich does not exist on Mac. Well, MacOS is not UNIX I guess.A "good first issue" ticket was created:
#2563
I wanted to take a stab on this, however, unfortunately it looks like
TestPermissionDeniedwas already fixed. It now creates a proper temporary file and drops permissions viaChomod. The only thing that was left to be done was to remove the build tags.And this is exactly what this PR does. Tested on the latest MacOS on Macbook Pro M1, I believe Intel should be the same story.
Have a good one. Cheers.