Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quarkus): build time properties into file #5198

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Feb 28, 2024

Moving from maven based approach to a file approach in order to let be able to use any character which may be a limitation in pom.xml

Closes #5195

Release Note

fix(quarkus): build time properties into file

Copy link
Contributor

✔️ Unit test coverage report - coverage increased from 36.2% to 36.4% (+0.2%)

Copy link
Contributor

✔️ Unit test coverage report - coverage increased from 36.2% to 36.4% (+0.2%)

pkg/builder/quarkus.go Outdated Show resolved Hide resolved
@squakez squakez force-pushed the fix/builder_props branch 2 times, most recently from 54bc20a to 9ee19c1 Compare March 1, 2024 08:49
Copy link
Contributor

github-actions bot commented Mar 1, 2024

✔️ Unit test coverage report - coverage increased from 36.4% to 36.8% (+0.4%)

Moving from maven based approach to a file approach in order to let be able to use any character which may be a limitation in pom.xml

Closes apache#5195
@squakez squakez force-pushed the fix/builder_props branch from 9ee19c1 to 4da847a Compare March 1, 2024 10:02
Copy link
Contributor

github-actions bot commented Mar 1, 2024

✔️ Unit test coverage report - coverage increased from 36.4% to 36.8% (+0.4%)

@squakez squakez merged commit c4db7ac into apache:main Mar 1, 2024
15 checks passed
@squakez squakez deleted the fix/builder_props branch March 1, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builder property failure when using non xml tag characters
3 participants