fix(builder): strenghten matching dependencies heuristic #5187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of #5090 - FYI @lburgazzoli |
oscerd
approved these changes
Feb 27, 2024
|
✔️ Unit test coverage report - coverage increased from 36% to 36.2% (+0.2%) |
|
@squakez can you add some better release notes ? it is not clear to me what is the motivation of this change and how it differs form the current behavior and what would be the impact. |
Sure. Done. Thanks. |
lburgazzoli
approved these changes
Feb 27, 2024
gansheer
approved these changes
Feb 27, 2024
It failed when we had odd number of dependencies
squakez
force-pushed
the
chore/strenght_tests
branch
from
08452f6 to
6ca3ba8
Compare
|
✔️ Unit test coverage report - coverage increased from 36% to 36.2% (+0.2%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TestRunBuildOrderStrategyMatchingDependenciesuses to be flaky. I've investigated and the root cause seems to be the heuristic we are using to detect matching dependencies. The following piece of codemissing >= len(required)/2seem to be the problem, in the sense that when the number ofrequiredis odd, then, the code is rounded to a integer value that is not matching the condition. The ideal solution is to add +1 to that division, or removing the equality which would sort the same effect.This PR address the problem. The heuristic used is strengthen against this corner case and validated with a few unit test.
Release Note