Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(build): Add Build waiting condition #5157

Merged
merged 1 commit into from
Feb 28, 2024
Merged

feat(build): Add Build waiting condition #5157

merged 1 commit into from
Feb 28, 2024

Conversation

gansheer
Copy link
Contributor

  • Add on Build.Status a "Scheduled" condition containing the reason for it's scheduling status

Ref #4542

Release Note

feat(build): Add Build waiting condition

squakez
squakez requested changes Feb 15, 2024
View reviewed changes
e2e/builder/build_test.go Outdated Show resolved Hide resolved
pkg/controller/build/build_monitor.go Outdated Show resolved Hide resolved
pkg/controller/build/build_monitor.go Outdated Show resolved Hide resolved
pkg/controller/build/schedule.go Outdated Show resolved Hide resolved
@gansheer gansheer force-pushed the feat/4542_wait_condition branch from 855544b to 06c6631 Compare February 15, 2024 14:54
squakez
squakez approved these changes Feb 15, 2024
View reviewed changes
pkg/controller/build/schedule.go Outdated Show resolved Hide resolved
pkg/controller/build/build_monitor.go Outdated Show resolved Hide resolved
@gansheer gansheer force-pushed the feat/4542_wait_condition branch 4 times, most recently from a311d5b to e43b6b2 Compare February 16, 2024 10:16
@gansheer gansheer force-pushed the feat/4542_wait_condition branch 4 times, most recently from 8d85223 to c8065d8 Compare February 22, 2024 08:18
@gansheer gansheer marked this pull request as ready for review February 22, 2024 08:19
@squakez
Copy link
Contributor

squakez commented Feb 23, 2024

@gansheer please, rebase against main as we have fixed the errored check.

@gansheer
feat(build): Add Build waiting condition
a982d51 
* Add on Build.Status a "Scheduled" condition containing the reason for it's scheduling status

Ref apache#4542
@gansheer gansheer force-pushed the feat/4542_wait_condition branch from c8065d8 to a982d51 Compare February 23, 2024 11:34
@christophd christophd merged commit 4b38fc1 into apache:main Feb 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squakez squakez squakez approved these changes

@oscerd oscerd oscerd approved these changes

@lburgazzoli lburgazzoli lburgazzoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gansheer @squakez @lburgazzoli @oscerd @christophd