-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#4916): Improve component resolver #4919
fix(#4916): Improve component resolver #4919
Conversation
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage changed: 33.5% --> 33.6% (Coverage difference: +.1%) |
@gansheer @squakez @claudio4j any idea why the validate CI job could be failing? |
" Error: File is not Checkstyles formatting I guess. |
In the prepare sections there are many |
@squakez I do not have the |
The error is not from your PR. The This PR will fix your issue after its merge. |
- Support URL query parameters when resolving components by given scheme - Do not resolve URLs that use parameter placeholder as a scheme - Properly extract scheme from URL that has query parameters
9bc48ff
to
00c7731
Compare
@gansheer many thanks! I have merged your PR and rebased this one so lets see those CI jobs becoming green now |
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage changed: 33.5% --> 33.6% (Coverage difference: +.1%) |
Fixes #4916
Release Note