-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added build-catalog-tool-timeout parameter to install command. #4821
Conversation
Added CAMEL_K_BUILD_CATALOG_TOOL_TIMEOUT to e2e tests to leverage the new install parameter. Updated doc.
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage unchanged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be missing something, but I am not sure this is a good idea to add a flag on a deprecated field :
camel-k/pkg/apis/camel/v1/integrationplatform_types.go
Lines 127 to 129 in 75fd59d
// the timeout (in seconds) to use when creating the build tools container image | |
// Deprecated: no longer in use | |
BuildCatalogToolTimeout *metav1.Duration `json:"buildCatalogToolTimeout,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field is deprecated. It is already not used in version 2.1 where we got rid off dynamic builder catalog.
If 2.0.x is going to have patch releases, we need to merge this one. |
In case we should do on |
We are still publishing the nightly for 2.0.2 |
If 2.0.x is not going to be released anymore, we should avoid publishing nightly. This PR is not dangerous and I think the target is the nightly release, so we could merge and in case there will be any future release it will be there, in case not, there is always the nightly. |
Yes. The target of this PR is |
Ah, maybe I should check the branch before commenting nonsense! |
Co-authored-by: Gaëlle Fournier <[email protected]>
Co-authored-by: Gaëlle Fournier <[email protected]>
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage unchanged. |
1 similar comment
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage unchanged. |
Added
build-catalog-tool-timeout
parameter to theinstall
command.Added
CAMEL_K_BUILD_CATALOG_TOOL_TIMEOUT
to e2e tests scripts to leverage the new install parameter.Updated doc.
Small addition to .gitignore
This is useful in environment where the default timeout of 2 minutes is not sufficient.
Release Note