Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): Add installation with helm,kustomize,olm securityContext re… #4787

Merged

Conversation

gansheer
Copy link
Contributor

@gansheer gansheer commented Oct 3, 2023

Fix #4786

Description

Add e2e tests installation with helm,kustomize,olm securityContext restricted validation

Release Note

fix(e2e): Add installation with helm,kustomize,olm securityContext restricted

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However, in general, I'd avoid to introduce reflection.

@gansheer
Copy link
Contributor Author

gansheer commented Oct 3, 2023

Looks good. However, in general, I'd avoid to introduce reflection.

Noted. Do you want me to change the current PR ?

@squakez
Copy link
Contributor

squakez commented Oct 3, 2023

@gansheer as you prefer. If it's not that much effort, maybe it is a good idea to avoid adding reflection and managing later.

@squakez
Copy link
Contributor

squakez commented Oct 4, 2023

@gansheer can you please confirm if you're finally going to address the reflection or can I merge this the way it is? Thanks!

@gansheer
Copy link
Contributor Author

gansheer commented Oct 4, 2023

@gansheer can you please confirm if you're finally going to address the reflection or can I merge this the way it is? Thanks!

I knew I forgot something 😅 . Yes I am taking care of it and will fix the CLI test as well.

@gansheer gansheer force-pushed the feat/4786_restricted_namespaces_operator branch from 59013b5 to 9a97c6f Compare October 4, 2023 08:01
@squakez squakez merged commit dc25083 into apache:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camel K doesn't install on a restricted namespace
3 participants