-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2e): Fix E2E test using kamelet my-own-timer-source #4753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It's a best practice to use a different resource name. The problem is likely to be fixed, but the root cause probably will be there.
I agree, I could not find quickly the root cause. It could be some parallel test execution issue as the common tests run on a preinstalled operator. |
9e524db
to
55ec887
Compare
It seems the change is breaking some other e2e test, is it that? |
Unfortunately no, the one still in error was already failing before. I can't reproduce this failure on local env. I will comment the code for now and add a comment in the current issue. As it is, it is not a documented behavior. I will keep it commented in case the failure become the signal we have another issues with kamelets. |
0406a00
to
5cc9867
Compare
5cc9867
to
18c4182
Compare
@squakez I think the refactoring fixed the issue. I am firing the CI to ensure the other failures were from an external source. |
Okey. However, there's no need to force push just for re-running checks. Please ping any committer to just re-run the failing one in order to shorten the feedback cycle. |
ref #4750
Description
Remove duplicate usage of "my-own-timer-source" kamelet.
Release Note