Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): Fix E2E test using kamelet my-own-timer-source #4753

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

gansheer
Copy link
Contributor

ref #4750

Description

Remove duplicate usage of "my-own-timer-source" kamelet.

Release Note

fix(e2e): Fix E2E test using kamelet my-own-timer-source

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's a best practice to use a different resource name. The problem is likely to be fixed, but the root cause probably will be there.

@gansheer
Copy link
Contributor Author

LGTM. It's a best practice to use a different resource name. The problem is likely to be fixed, but the root cause probably will be there.

I agree, I could not find quickly the root cause. It could be some parallel test execution issue as the common tests run on a preinstalled operator.

@gansheer gansheer force-pushed the fix/e2e_test_error_on_kamelets branch 2 times, most recently from 9e524db to 55ec887 Compare September 18, 2023 06:41
@squakez
Copy link
Contributor

squakez commented Sep 18, 2023

It seems the change is breaking some other e2e test, is it that?

@gansheer
Copy link
Contributor Author

gansheer commented Sep 18, 2023

It seems the change is breaking some other e2e test, is it that?

Unfortunately no, the one still in error was already failing before. I can't reproduce this failure on local env.

I will comment the code for now and add a comment in the current issue. As it is, it is not a documented behavior. I will keep it commented in case the failure become the signal we have another issues with kamelets.

@gansheer gansheer force-pushed the fix/e2e_test_error_on_kamelets branch 4 times, most recently from 0406a00 to 5cc9867 Compare September 19, 2023 14:19
@gansheer gansheer force-pushed the fix/e2e_test_error_on_kamelets branch from 5cc9867 to 18c4182 Compare September 19, 2023 17:03
@gansheer
Copy link
Contributor Author

@squakez I think the refactoring fixed the issue. I am firing the CI to ensure the other failures were from an external source.

@squakez
Copy link
Contributor

squakez commented Sep 20, 2023

@squakez I think the refactoring fixed the issue. I am firing the CI to ensure the other failures were from an external source.

Okey. However, there's no need to force push just for re-running checks. Please ping any committer to just re-run the failing one in order to shorten the feedback cycle.

@squakez squakez merged commit 2a12303 into apache:main Sep 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants