feat: knative service trait annotation support #4729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Sep 11, 2023
|
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage unchanged. |
claudio4j
reviewed
Sep 11, 2023
claudio4j
reviewed
Sep 11, 2023
squakez
requested changes
Sep 12, 2023
|
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage unchanged. |
|
I had a look at these issues, the annotations should be appending now and the test should use the correct environment as well. Doc is also displaying the example trait correctly. |
squakez
approved these changes
Sep 13, 2023
|
Also run a |
|
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage unchanged. |
squakez
pushed a commit
to squakez/camel-k
that referenced
this pull request
Oct 11, 2023
* feat: annotation support for knative svc trait * doc: annotation documentation * chore: test fix, annotation append, doc edit * chore: generated docs --------- Co-authored-by: Martin Olsiak <[email protected]>
squakez
pushed a commit
to squakez/camel-k
that referenced
this pull request
Oct 11, 2023
* feat: annotation support for knative svc trait * doc: annotation documentation * chore: test fix, annotation append, doc edit * chore: generated docs --------- Co-authored-by: Martin Olsiak <[email protected]>
squakez
pushed a commit
to jboss-fuse/camel-k
that referenced
this pull request
Oct 11, 2023
* feat: annotation support for knative svc trait * doc: annotation documentation * chore: test fix, annotation append, doc edit * chore: generated docs --------- Co-authored-by: Martin Olsiak <[email protected]>
squakez
pushed a commit
to jboss-fuse/camel-k
that referenced
this pull request
Nov 3, 2023
* feat: annotation support for knative svc trait * doc: annotation documentation * chore: test fix, annotation append, doc edit * chore: generated docs --------- Co-authored-by: Martin Olsiak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI parameter usage example for clarity:
-t "knaive-service.annotations.'haproxy.router.openshift.io/balance'=true"This can be repeated to add multiple annotations
Release Note