Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize project to have a single Go module #4690

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Reorganize project to have a single Go module #4690

merged 1 commit into from
Aug 28, 2023

Conversation

claudio4j
Copy link
Contributor

@claudio4j claudio4j commented Aug 24, 2023 •
edited
Loading

Fix #4686 and #4683

Release Note

Reorganize project to have a single Go module

@claudio4j claudio4j requested a review from squakez August 24, 2023 02:15
@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ⚠️ - Coverage changed: 39.0% --> 33.4% (Coverage difference: -5.6%)

1 similar comment
@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ⚠️ - Coverage changed: 39.0% --> 33.4% (Coverage difference: -5.6%)

squakez
squakez reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check also the usage of make set-module-version which is performed during the release processes.

script/gen_crd/gen-kamelets-crd-api-config.json Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ⚠️ - Coverage changed: 39.0% --> 33.4% (Coverage difference: -5.6%)

@claudio4j claudio4j marked this pull request as ready for review August 24, 2023 17:54
@claudio4j
Copy link
Contributor Author

@squakez @christophd can you make a final review ?
This fix is important for camel-kamelets 4.0 release, to use the new Pipe api.

@oscerd
Copy link
Contributor

oscerd commented Aug 28, 2023

@squakez should be out this week. @christophd can you take a look?

@claudio4j
Copy link
Contributor Author

Once we merge it, there should be a Camel K release, to publish the Camel K 2.x Go modules to go.dev repo.

@claudio4j claudio4j merged commit 1a32b64 into apache:main Aug 28, 2023
@oscerd
Copy link
Contributor

oscerd commented Aug 28, 2023

I can release if needed

@oscerd
Copy link
Contributor

oscerd commented Aug 28, 2023

Should this be 2.1.0 or 2.0.1? If 2.0.1, do we need to backport this change? It seems a breaking change.

@claudio4j claudio4j mentioned this pull request Aug 28, 2023
Closed
@claudio4j
Copy link
Contributor Author

claudio4j commented Aug 28, 2023 •
edited
Loading

I will backport to the 2.0 release branch and a 2.0.1 release can be done.
There should not be a breaking change, since the 2.0.0 golang import was not possible.

@claudio4j claudio4j deleted the fix_single_gomod branch August 28, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squakez squakez squakez left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rearrange Go modules
3 participants
@claudio4j @oscerd @squakez