-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added annotations support for route trait #4664
feat: added annotations support for route trait #4664
Conversation
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage unchanged. |
The trait parameter should be prefixed with the trait name, so given the example in the description, should it be ?
There is Also, how to add a second annotation ? It would be good to add it as example in the description. |
I must have made a mistake when writing documentation, it should be fixed now. |
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage unchanged. |
You can repeat it multiple times for multiple annotations in a single line. |
* Added annotation support for Route trait * chore: added unit test * chore: added unit tests for route annotations * doc: added annotations documentation * doc: cli example edit * chore: unit test edit * chore: fixed documentation example --------- Co-authored-by: Martin Olsiak <[email protected]>
* Added annotation support for Route trait * chore: added unit test * chore: added unit tests for route annotations * doc: added annotations documentation * doc: cli example edit * chore: unit test edit * chore: fixed documentation example --------- Co-authored-by: Martin Olsiak <[email protected]>
* Added annotation support for Route trait * chore: added unit test * chore: added unit tests for route annotations * doc: added annotations documentation * doc: cli example edit * chore: unit test edit * chore: fixed documentation example --------- Co-authored-by: Martin Olsiak <[email protected]>
* Added annotation support for Route trait * chore: added unit test * chore: added unit tests for route annotations * doc: added annotations documentation * doc: cli example edit * chore: unit test edit * chore: fixed documentation example --------- Co-authored-by: Martin Olsiak <[email protected]>
CLI parameter usage example for clarity:
-t "route.annotations.'haproxy.router.openshift.io/balance'=true"
This can be repeated to add multiple annotations
Release Note