Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added annotations support for route trait #4664

Merged
merged 7 commits into from
Aug 11, 2023

Conversation

realMartinez
Copy link
Contributor

@realMartinez realMartinez commented Aug 10, 2023

- Added route annotations implementation
- Added unit tests
- Added documentation

CLI parameter usage example for clarity:
-t "route.annotations.'haproxy.router.openshift.io/balance'=true"
This can be repeated to add multiple annotations

Release Note

feat: added annotations support for route trait

@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage unchanged.

@claudio4j
Copy link
Contributor

claudio4j commented Aug 10, 2023

The trait parameter should be prefixed with the trait name, so given the example in the description, should it be ?

-t route.annotations "haproxy.router.openshift.io/balance'=true"

There is ' at the end of balance', where is the initial sign ? I am asking because, given the attribute is a map[string]string, I can't remember how that is set from a CLI perspective.

Also, how to add a second annotation ? It would be good to add it as example in the description.

@realMartinez
Copy link
Contributor Author

-t route.annotations "haproxy.router.openshift.io/balance'=true"


There is `'` at the end of `balance'`, where is the initial sign ? I am asking because, given the attribute is a `map[string]string`, I can't remember how that is set from a CLI perspective.

I must have made a mistake when writing documentation, it should be fixed now.

@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage unchanged.

@realMartinez
Copy link
Contributor Author

Also, how to add a second annotation ? It would be good to add it as example in the description.

You can repeat it multiple times for multiple annotations in a single line.

@squakez squakez merged commit 1207e6a into apache:main Aug 11, 2023
squakez pushed a commit to squakez/camel-k that referenced this pull request Oct 11, 2023
* Added annotation support for Route trait

* chore: added unit test

* chore: added unit tests for route annotations

* doc: added annotations documentation

* doc: cli example edit

* chore: unit test edit

* chore: fixed documentation example

---------

Co-authored-by: Martin Olsiak <[email protected]>
squakez pushed a commit to squakez/camel-k that referenced this pull request Oct 11, 2023
* Added annotation support for Route trait

* chore: added unit test

* chore: added unit tests for route annotations

* doc: added annotations documentation

* doc: cli example edit

* chore: unit test edit

* chore: fixed documentation example

---------

Co-authored-by: Martin Olsiak <[email protected]>
squakez pushed a commit to jboss-fuse/camel-k that referenced this pull request Oct 11, 2023
* Added annotation support for Route trait

* chore: added unit test

* chore: added unit tests for route annotations

* doc: added annotations documentation

* doc: cli example edit

* chore: unit test edit

* chore: fixed documentation example

---------

Co-authored-by: Martin Olsiak <[email protected]>
squakez pushed a commit to jboss-fuse/camel-k that referenced this pull request Nov 3, 2023
* Added annotation support for Route trait

* chore: added unit test

* chore: added unit tests for route annotations

* doc: added annotations documentation

* doc: cli example edit

* chore: unit test edit

* chore: fixed documentation example

---------

Co-authored-by: Martin Olsiak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants