Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): improve kamel promote #4621

Merged
merged 3 commits into from
Aug 1, 2023
Merged

feat(cmd): improve kamel promote #4621

merged 3 commits into from
Aug 1, 2023

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Jul 28, 2023

This PR addresses a few enhancements which are helping GitOps or in general deployment operations. They are following up the some limitations founds in the proposed Camel K GitOps strategy.

First of all, we get rid of the destination checks when in dry-run mode. Second, we introduce a simple flag which helps putting in place any unopinionated deployment strategy, for example:

$ kamel promote test -i --to test
10.110.251.124/default/camel-k-kit-cj1ra5e9j3ks738a7bbg@sha256:99835a5da746fc3d7f96d0ae50c64df0e29eb3e8d131e61bfdfd617fdaa078ba

Finally we allow to specify the operator ID tenant which must be used to take care of the promoted integration, ie kamel promote test -x my-production-operator-id --to test

Closes #4534
Closes #3890

Release Note

feat(cmd): improve `kamel promote`

squakez added 2 commits July 28, 2023 14:52
Ability to show the container image used in some integration
@squakez squakez added the kind/feature New feature or request label Jul 28, 2023
@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ⚠️ - Coverage changed: 39.4% --> 39.1% (Coverage difference: -.3%)

@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ⚠️ - Coverage changed: 39.4% --> 39.1% (Coverage difference: -.3%)

@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ⚠️ - Coverage changed: 39.4% --> 39.1% (Coverage difference: -.3%)

@squakez
Copy link
Contributor Author

squakez commented Aug 1, 2023

The check failure should not be related to this change. I'll merge and have a look if it still fail after the push on main.

@squakez squakez merged commit 3988ba3 into apache:main Aug 1, 2023
@squakez squakez deleted the feat/4534 branch August 1, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kamel promote dry run should not validate kamel promote with new tenancy model
2 participants