Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(trait): Add user documentation on maven profile trait #4615

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

gansheer
Copy link
Contributor

Ref #4560

Release Note

NONE

@gansheer gansheer changed the title doc(trait): Add some documentation on maven profile trait doc(trait): Add user documentation on maven profile trait Jul 26, 2023
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these kind of contents deserves their own space. You can add a new entry under "run and Integration" navigation, ie "Customize build". I think that we will eventually add even more content in this page.

@squakez
Copy link
Contributor

squakez commented Jul 26, 2023

I had a look at the doc structure, definitely better under "configuration" nav.

@gansheer gansheer force-pushed the doc/4560_maven_profile branch from cf01471 to 991616b Compare July 26, 2023 13:52
@gansheer
Copy link
Contributor Author

@squakez It should be better now - I think. I added a maven-profile section in configuration. If you want me to change it to configuration > Customize build > Maven Profile don't hesitate to tell me 🙇‍♀️ .

@squakez
Copy link
Contributor

squakez commented Jul 26, 2023

Thanks. You need also to add the link in the navigation, somewhere under

* xref:configuration/configuration.adoc[Configuration]

@gansheer gansheer force-pushed the doc/4560_maven_profile branch from 991616b to eede18d Compare July 26, 2023 15:15
@squakez squakez merged commit 925f3af into apache:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants